Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67381432
I tested this out and it looks good to me, so I'm going to merge this into
`master`, `branch-1.2`, and `branch-1.1`. Thanks for fixing this!
---
If your project is
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3444
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67382686
Actually, it looks like this issue doesn't affect 1.1.1, since I'm able to
browse to `/metrics/json` after starting `spark-shell`. Therefore, I'm not
merging this
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67217026
I'm finally getting around to reviewing this now. Is there a good way to
test this? What's the error message / symptom thatI should look for in the
buggy version of
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67220069
Ah, this was actually a pretty nasty bug since it seems to silently fail!
I'm fine merging this patch to fix this issue, but I wonder whether there
are other
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67222433
I've opened a PR against this PR in order to add defensive checks to
MetricsSystem, which would have prevented the issue fixed by this PR:
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67262226
Thanks a lot Josh, I will merge into this PR and update the code :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67263058
[Test build #24520 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24520/consoleFull)
for PR 3444 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67269456
[Test build #24520 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24520/consoleFull)
for PR 3444 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-67269459
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-64328090
[Test build #23822 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23822/consoleFull)
for PR 3444 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-64328095
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/3444
[SPARK-4595][Core] Fix MetricsServlet not work issue
`MetricsServlet` handler should be added to the web UI after initialized by
`MetricsSystem`, otherwise servlet handler cannot be attached.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3444#issuecomment-64320122
[Test build #23822 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23822/consoleFull)
for PR 3444 at commit
14 matches
Mail list logo
