Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-68101164
ping @tdas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3464#discussion_r22275984
--- Diff: docs/streaming-programming-guide.md ---
@@ -66,7 +66,6 @@ main entry point for all streaming functionality. We
create a local StreamingCon
{%
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3464#discussion_r22276020
--- Diff:
streaming/src/test/scala/org/apache/spark/streamingtest/ImplicitSuite.scala ---
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-68116003
LGTM, except one comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3464#discussion_r22277047
--- Diff:
streaming/src/test/scala/org/apache/spark/streamingtest/ImplicitSuite.scala ---
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-68118318
[Test build #24826 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24826/consoleFull)
for PR 3464 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-68120641
[Test build #24826 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24826/consoleFull)
for PR 3464 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-68120643
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-68121248
Merging this. Thanks @zsxwing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3464
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-65358489
ping @tdas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64581017
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64580965
[Test build #23887 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23887/consoleFull)
for PR 3464 at commit
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/3464
[SPARK-4608][Streaming] Reorganize StreamingContext implicit to improve API
convenience
There is only one implicit function `toPairDStreamFunctions` in
`StreamingContext`. This PR did similar
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64507265
/cc @tdas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64507283
[Test build #23864 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23864/consoleFull)
for PR 3464 at commit
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64507501
Could you add a test to test that this actually works without importing
StreamignContext._ ?
Also it would be great if all the StreamingContext._ in different files can
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64507587
Could you add a test to test that this actually works without importing
StreamignContext._ ?
Do you mean
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64510396
Also it would be great if all the StreamingContext._ in different files
can be removed, which would make this more reliable.
Done.
---
If your project is set
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/3464#discussion_r20914831
--- Diff: docs/streaming-programming-guide.md ---
@@ -66,7 +66,6 @@ main entry point for all streaming functionality. We
create a local StreamingCon
{%
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64510671
[Test build #23871 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23871/consoleFull)
for PR 3464 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3464#discussion_r20914985
--- Diff: docs/streaming-programming-guide.md ---
@@ -66,7 +66,6 @@ main entry point for all streaming functionality. We
create a local StreamingCon
{%
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64511101
[Test build #23872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23872/consoleFull)
for PR 3464 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64511344
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64511339
[Test build #23864 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23864/consoleFull)
for PR 3464 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64512550
This patch adds the following public classes (experimental):
class CompressedSerializer(FramedSerializer):
Some bug in the detecting codes? This PR doesn't
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64515358
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64516017
[Test build #23872 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23872/consoleFull)
for PR 3464 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3464#issuecomment-64516021
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
29 matches
Mail list logo
