Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104853605
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104853606
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104853602
[Test build #33391 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33391/consoleFull)
for PR 3920 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104823914
@GenTang Can you check that these examples working with latest master? If
yes, I will merge it now.
---
If your project is set up for it, you can reply to this email
Github user GenTang commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104841817
@davies I just tested it with the assembly of master branch, it works.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104842587
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104842624
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104842719
[Test build #33391 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33391/consoleFull)
for PR 3920 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-104842642
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-98603768
@davies should be good to merge now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-96769849
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user GenTang commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-77252529
Hi, I am sorry to bother you all.
But is this pull request OK for merging, please?
---
If your project is set up for it, you can reply to this email and have your
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r25155799
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -18,20 +18,34 @@
package
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-75582752
@GenTang This PR looks good to me now, thanks
@JoshRosen I think it's ready to go.
---
If your project is set up for it, you can reply to this email and have
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r25180080
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -18,20 +18,34 @@
package
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r25182187
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -18,20 +18,34 @@
package
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r25145679
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -18,20 +18,34 @@
package
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24719372
--- Diff: examples/src/main/python/hbase_inputformat.py ---
@@ -16,6 +16,7 @@
#
import sys
+import simplejson as json
--- End diff --
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24719439
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -18,20 +18,34 @@
package
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24727321
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -18,20 +18,34 @@
package
Github user GenTang commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-74393987
@davies
Now we return the string in json format.
Therefore the specific characters such as `'` or `` don't cause problem
any more.
---
If your project is set
Github user GenTang commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-73889175
@davies @MLnick
Perhaps it is not a good place to discuss this, but I tried the script
hbase_outputformat.py in spark 1.2.0 and it caused
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24495658
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24184139
--- Diff: examples/src/main/python/hbase_inputformat.py ---
@@ -72,6 +75,9 @@
keyConverter=keyConv,
valueConverter=valueConv,
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24184482
--- Diff: examples/src/main/scala/org/apache/spark/examples/HBaseTest.scala
---
@@ -36,7 +36,7 @@ object HBaseTest {
// Initialize hBase table if
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24185498
--- Diff: examples/src/main/python/hbase_inputformat.py ---
@@ -72,6 +75,9 @@
keyConverter=keyConv,
valueConverter=valueConv,
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24187737
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24187753
--- Diff: examples/src/main/python/hbase_inputformat.py ---
@@ -72,6 +75,9 @@
keyConverter=keyConv,
valueConverter=valueConv,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24187984
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24188162
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24188212
--- Diff: examples/src/main/python/hbase_inputformat.py ---
@@ -72,6 +75,9 @@
keyConverter=keyConv,
valueConverter=valueConv,
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24188381
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24184037
--- Diff: examples/src/main/scala/org/apache/spark/examples/HBaseTest.scala
---
@@ -36,7 +36,7 @@ object HBaseTest {
// Initialize hBase table if
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r24184650
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-71476341
@GenTang ok, thanks for updating the example data. I checked out the PR and
tested quickly locally, the new example and data works for me. Looks good.
@davies +1
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r23414030
--- Diff: examples/src/main/python/hbase_inputformat.py ---
@@ -16,6 +16,7 @@
#
import sys
+import ast
from pyspark import
Github user GenTang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r23413908
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user GenTang commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-71121501
@MLnick I change the sample data to show that we can have several records
in one columnFamily.
In fact, in HBase 0.96 and newer, the default maximum number of
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r23403193
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-71085426
@GenTang overall looks fine to me - just noted a few minor comments /
questions, and in particular it would be good to expand on the sample data in
the example just to
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r23403050
--- Diff:
examples/src/main/scala/org/apache/spark/examples/pythonconverters/HBaseConverters.scala
---
@@ -23,15 +23,27 @@ import
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/3920#discussion_r23403597
--- Diff: examples/src/main/python/hbase_inputformat.py ---
@@ -16,6 +16,7 @@
#
import sys
+import ast
from pyspark import
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-70049746
@GenTang Sorry for the delay, have been travelling. I will try to get to
this in the next few days.
---
If your project is set up for it, you can reply to this email
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/3920#issuecomment-69404136
OK to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
45 matches
Mail list logo
