Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4039
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-82687233
I believe this problem has been fixed and we can close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-71887315
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-71887893
[Test build #26237 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26237/consoleFull)
for PR 4039 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-71900510
[Test build #26237 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26237/consoleFull)
for PR 4039 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-71900517
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-71537019
The sole purpose of adding `SpecificMutableRow` is to avoid boxing cost, so
using `boxed` here doesn't sound good. For SPARK-5236, schema mismatch can
often produce
Github user alexbaretta commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-70019159
@squito This is not new functionality for which it would make sense to
write a unit test. This is a hotfix for a bug. I am completely unfamiliar with
this code, but
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-70014846
can you add a unit test for what this fixes? I don't see how this avoids
the exceptions, just seems to push them down into `MutableValue.update`. A
test case would help
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-70036427
btw, while you're mucking around in there ... it might be nice to change
the `SpecificMutableRow` constructor to take varargs. Change this constructor:
```
-
Github user alexbaretta commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-70036683
Ok, happy to look into this, but I will be out for the next few days, so
this isn't going to happen before the weekend.
---
If your project is set up for it, you
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-70036236
I think finding fixing a bug in current behavior is a great reason to add
a unit test. Some part of the implementation is confusing enough to have
allowed a bug in the
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-70037269
Back to the question of something deeper being wrong ...
I think we'll need to wait for input from somebody more familiar w/ this
code. @marmbrus ?
But one
GitHub user alexbaretta opened a pull request:
https://github.com/apache/spark/pull/4039
[SPARK-5236] Fix ClassCastException in SpecificMutableRow
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alexbaretta/spark
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4039#issuecomment-69878601
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
15 matches
Mail list logo
