[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9404#discussion_r43715526 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala --- @@ -194,12 +194,13 @@ case class Exchange(newPartitioning: Partitioning, ch

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9404 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153230502 LGTM. I am going to merge this. @nongli Can you have a follow-up to address those two minor comments? Thanks! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153222808 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153222811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153222410 **[Test build #44855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44855/consoleFull)** for PR 9404 at commit [`8428541`](https://git

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9404#discussion_r43709146 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala --- @@ -194,12 +194,13 @@ case class Exchange(newPartitioning: Partitioning, ch

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9404#discussion_r43709117 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -353,4 +354,62 @@ class CachedTableSuite extends QueryTest with SharedSQLC

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9404#discussion_r43708751 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala --- @@ -229,12 +230,33 @@ private[sql] case class EnsureRequirements(sqlContext

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153203733 **[Test build #44855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44855/consoleFull)** for PR 9404 at commit [`8428541`](https://gith

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153202279 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153202255 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153144952 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153144949 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153144771 **[Test build #44817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44817/consoleFull)** for PR 9404 at commit [`e711e05`](https://git

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9404#discussion_r43662693 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -353,4 +354,44 @@ class CachedTableSuite extends QueryTest with SharedSQLC

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153104224 **[Test build #44817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44817/consoleFull)** for PR 9404 at commit [`e711e05`](https://gith

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/9404#discussion_r43660128 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala --- @@ -353,4 +354,44 @@ class CachedTableSuite extends QueryTest with SharedSQLC

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153100484 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153100427 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153099409 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153099394 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-02 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-153099382 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9404#issuecomment-152917550 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-5354] [SQL] Cached tables should preser...

2015-11-01 Thread nongli
GitHub user nongli opened a pull request: https://github.com/apache/spark/pull/9404 [SPARK-5354] [SQL] Cached tables should preserve partitioning and ord… …ering. For cached tables, we can just maintain the partitioning and ordering from the source relation. You ca