[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4523 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-11 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/4523#issuecomment-73873410 I applied this changes and confirmed. It's LGTM, thanks @marsishandsome ! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4523#issuecomment-73852648 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27

[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4523#issuecomment-73852640 [Test build #27281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27281/consoleFull) for PR 4523 at commit [`9d7b593`](https://gith

[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-11 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4523#issuecomment-73849848 Just from reading this page, LGTM. Seems clear that the utility function should be used everywhere to make the page link. Ideally @sarutak can confirm (see https://github.

[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4523#issuecomment-73845166 [Test build #27281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27281/consoleFull) for PR 4523 at commit [`9d7b593`](https://githu

[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4523#issuecomment-73844774 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4523#issuecomment-73837491 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-5733] Error Link in Pagination of Histr...

2015-02-10 Thread marsishandsome
GitHub user marsishandsome opened a pull request: https://github.com/apache/spark/pull/4523 [SPARK-5733] Error Link in Pagination of HistroyPage when showing Incomplete Applications The links in pagination of HistroyPage is wrong when showing Incomplete Applications. If "2