Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-193380455
@anirudhcelebal please ask questions on the spark-user list instead of PRs.
`explode` only works with arrays. you probably want something like `SELECT
fare.*
Github user anirudhcelebal commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-192877517
root
|-- adultbasefare: long (nullable = true)
|-- adultcommission: long (nullable = true)
|-- adultservicetax: long (nullable = true)
|--
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84969583
[Test build #28994 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28994/consoleFull)
for PR 4697 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84969598
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84891332
[Test build #28985 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28985/consoleFull)
for PR 4697 at commit
Github user anselmevignon commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-85158386
I closing it, thanks a lot everyone for the merge, the review, and the
patience with newbyism :)
Anselme
---
If your project is set up for it, you can
Github user anselmevignon closed the pull request at:
https://github.com/apache/spark/pull/4697
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-85147635
Mind closing this now? PRs to branches other than master do not auto close.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user anselmevignon commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84908406
Should be better now. Would you mind commenting here if there are updates
needed, I seem to have trouble receiving notifications from the inline
comments.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84939871
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84936129
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84936098
[Test build #28985 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28985/consoleFull)
for PR 4697 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84940364
[Test build #28994 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28994/consoleFull)
for PR 4697 at commit
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-85147251
Thanks! Merged to branch-1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-84451800
Looks like there is only two small style comments before this can be
merged. Thanks for working on it! Would you mind also updating the
description. I believe it
Github user anselmevignon commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-76680120
Hi @ayoub-benali,
Sorry for the delay, I was OOO during the end of the week.
I will be correcting the style and getting rid of the dynamic type
Github user anselmevignon commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25587002
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -263,6 +356,22 @@ abstract class ParquetTest extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-76741937
[Test build #28176 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28176/consoleFull)
for PR 4697 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-76759240
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-76759222
[Test build #28176 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28176/consoleFull)
for PR 4697 at commit
Github user ayoub-benali commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-76593597
Hi @anselmevignon, would you mind fixing the styling issues so that PR get
merged in 1.2 branch ?
if you don't plan to work on it any more, could you allow me to
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-76623990
Since it has been fixed in master and branch-1.3, it will be great if we
can have the same changes with aa39460d4bb4c41084d350ccb1c5a56cd61239b7 for
branch-1.2.
---
If
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457449
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -263,6 +356,22 @@ abstract class ParquetTest extends QueryTest
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457373
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -171,9 +231,40 @@ abstract class ParquetTest extends QueryTest
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457393
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -263,6 +356,22 @@ abstract class ParquetTest extends QueryTest
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457259
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -70,6 +72,38 @@ class ParquetMetastoreSuite extends ParquetTest {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457406
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -263,6 +356,22 @@ abstract class ParquetTest extends QueryTest
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-76250548
Hey @anselmevignon, because 1.3 release is really close, I just made #4697
based on your work, but target to master and branch-1.3. We can still polish
this PR (mainly
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457193
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -278,10 +278,18 @@ case class ParquetRelation2(path:
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457221
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -31,7 +31,9 @@ import org.apache.spark.sql.hive.test.TestHive._
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457332
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -171,9 +231,40 @@ abstract class ParquetTest extends QueryTest
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457280
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/parquet/parquetSuites.scala ---
@@ -70,6 +72,38 @@ class ParquetMetastoreSuite extends ParquetTest {
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4697#discussion_r25457171
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTableOperations.scala
---
@@ -144,19 +144,33 @@ case class ParquetTableScan(
Github user anselmevignon commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75384490
@ayoub-benali thanks for the review !
about SPARK-5508, the stacktrace really looks like the same as a similar
one I saw with a
Github user ayoub-benali commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75371721
@anselmevignon I just re-tested and it worked. Thanks :+1:
Little off topic, I checked also if this pull request would solve
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75242649
[Test build #2 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/2/consoleFull)
for PR 4697 at commit
Github user anselmevignon commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75259832
Hi Ayioub,
When did you pulled ? unfortunately I pulled a stupid version on my first
PR... basically there was an infionite loop in the fix
I
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75261678
[Test build #2 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/2/consoleFull)
for PR 4697 at commit
Github user ayoub-benali commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75258468
Just tried to reproduce the example in SPARK-5775 with the spark shell and
now it hangs for ever during query time.
Maybe because the tests don't reproduce the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75261697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75128095
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75128074
/cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75128452
[Test build #27734 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27734/consoleFull)
for PR 4697 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75111236
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user anselmevignon opened a pull request:
https://github.com/apache/spark/pull/4697
[SPARK-5775] BugFix: GenericRow cannot be cast to SpecificMutableRow when
nested data and partitioned table
The Bug solved here was due to a change in PartitionTableScan, when reading
a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75151308
**[Test build #27734 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27734/consoleFull)**
for PR 4697 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4697#issuecomment-75151319
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
47 matches
Mail list logo
