Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-75128516
@andrewor14 Ah! right of course. I looked right past that. Yes that's a
good change then.
---
If your project is set up for it, you can reply to this email and have your
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-75125804
@srowen it actually does a `=~` which should be equivalent to a grep:
```
if [[ abc =~ abc ]]; then echo woohoo; fi # woohoo
if [[ ffabc =~ abc ]]; then
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4611
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74842751
As I say on OS X you get the whole binary path, not just `java`:
```
ps -p ... -o comm=
...
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74965737
Bash style for this change is fine, though there are other areas in this
script with word splitting problems, unfortunately (e.g. some references to
`$option`).
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74799888
[Test build #27670 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27670/consoleFull)
for PR 4611 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74806519
[Test build #27670 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27670/consoleFull)
for PR 4611 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74806525
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74800315
Thank you @srowen , I've updated the script, seems much simpler.
Appreciated if you can confirm the change under OS X, sorry, I don't have
machine with OS X.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74650236
Gotcha. OK. Until someone thinks of a more robust check, I think we can
resort to just checking if `ps -p $pid -o comm=` is `java`?
---
If your project is set up for it,
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74538795
This uses `jps`, but that is only included with the JDK. I think it's
reasonable to expect many production deployments will only use the JRE. How
about simply `ps -p 4391
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74595309
@srowen, I was trying something like `ps -p 4391 | grep -q $command`, but
it doesn't work. The process name is always `java`, and the parameters are `-cp
x`,
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74596000
@chenghao-intel ah, looks like the default behavior on OS X is different
from Linux. Try `ps -f -p ...` on either one and it looks like you get
something containing the
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74617241
@srowen I've tested that both under ubuntu 12.04 and centos 6.5, `ps -f -p
...` only print the first 4096 characters of its arguments.
By the way, I've also
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74408762
[Test build #27510 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27510/consoleFull)
for PR 4611 at commit
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/4611
[SPARK-5825] [Spark Submit] Remove the double checking when killing process
`spark-daemon.sh` will confirm the process id by fuzzy matching the class
name while stopping the service,
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74406965
#4382 failed due to the `SparkSubmit`(HiveThriftServer) cannot be killed in
unit testing. Probably we need to manually kill those processes, or restart the
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74414416
I don't think we want to take out this check entirely. This was changed
recently to not just test whether the process can be killed (with `kill -0`) as
a way of testing
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74406895
[Test build #27510 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27510/consoleFull)
for PR 4611 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74408764
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74449462
Thank you @srowen for the explanation, I've updated the scripts, can you
review it again?
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74449523
[Test build #27537 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27537/consoleFull)
for PR 4611 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74453780
[Test build #27537 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27537/consoleFull)
for PR 4611 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4611#issuecomment-74453783
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
24 matches
Mail list logo
