Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-168112595
I'm going to close this pull request. If this is still relevant and you are
interested in pushing it forward, please open a new pull request. Thanks!
---
If your project
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-154272233
Does `docs/monitoring.md` need an update to include the new config?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-154272194
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4632#discussion_r44099630
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsConfig.scala
---
@@ -57,14 +59,16 @@ private[spark] class MetricsConfig(conf: SparkConf)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-154272326
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-154272305
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-154289768
**[Test build #45193 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45193/consoleFull)**
for PR 4632 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-154289985
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-154289989
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-154273416
**[Test build #45193 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45193/consoleFull)**
for PR 4632 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4632#discussion_r44099482
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -124,7 +124,7 @@ private[spark] class MetricsSystem private (
*
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4632#discussion_r44099446
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsConfig.scala
---
@@ -57,14 +59,16 @@ private[spark] class MetricsConfig(conf: SparkConf)
Github user paulbes commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-153745576
Being able to configure a fixed set of metrics names is something we are
also interested in, what is the progress on this work?
---
If your project is set up for it,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140208347
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140208319
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140233883
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140233827
[Test build #42444 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42444/console)
for PR 4632 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140233884
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user ryan-williams commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140235859
I'm not sure how to figure out what test failed from the Jenkins output
here
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42444/consoleFull
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140236069
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42444/testReport/
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140209080
[Test build #42444 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42444/consoleFull)
for PR 4632 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140179948
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140182767
[Test build #42437 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42437/console)
for PR 4632 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140182809
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140182808
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140179925
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-140180688
[Test build #42437 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42437/consoleFull)
for PR 4632 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-136974419
I have little knowledge of the metrics system. I can appreciate the
overhead of yet another config flag, and can also see how you might want to
monitor apps by instance
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-136915532
Perhaps @vanzin or @srowen can look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dajac commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-101239287
Hey @pwendell and @JoshRosen, what is the status on this?
I would like to monitor all my recurrent jobs and having fixed set of
metrics which doesn't change
Github user ryan-williams commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-85180665
Thanks @pwendell. I had stumbled across that
[SPARK-3377](https://issues.apache.org/jira/browse/SPARK-3377) work as well.
I think there are solid arguments
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-84209577
Hey @JoshRosen can probably take a look at this. One thing though, IIRC the
reason why we have a unique ID here is because some sets of users requested the
exact
Github user ryan-williams commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-82420712
bump, @pwendell any ideas who would be a good reviewer for this?
This is a pretty important piece of my
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-76441577
[Test build #28076 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28076/consoleFull)
for PR 4632 at commit
Github user ryan-williams commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-76444840
This one is ready for review, I think
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-76455746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-76455726
[Test build #28076 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28076/consoleFull)
for PR 4632 at commit
Github user ryan-williams commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-74578411
scala style check should pass now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-74577799
[Test build #27578 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27578/consoleFull)
for PR 4632 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-74577467
[Test build #27578 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27578/consoleFull)
for PR 4632 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-74577802
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
GitHub user ryan-williams opened a pull request:
https://github.com/apache/spark/pull/4632
[SPARK-5847] Allow for namespacing metrics by conf params other than
spark.app.id
You can merge this pull request into a Git repository by running:
$ git pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-74578739
[Test build #27581 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27581/consoleFull)
for PR 4632 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-74588350
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4632#issuecomment-74588341
[Test build #27581 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27581/consoleFull)
for PR 4632 at commit
46 matches
Mail list logo
