[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75123777 If we return a `JavaPairRDD`, the user code looks like the following: ~~~ for (Tuple2Long, Int assignment: assignments.collect()) { ... assignment._1()

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75121366 For PIC, the names Assignment / id / cluster sound good to me. Those would be applicable to other clustering methods if ever needed. Assignment is a little generic,

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75125808 LGTM except for that one comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/4695#discussion_r25020128 --- Diff: docs/mllib-frequent-pattern-mining.md --- @@ -74,11 +74,12 @@ Calling `FPGrowth.run` with transactions returns an that stores the frequent

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75125659 Yeah, after reading the code, I like the special classes since the field names make the code more legible. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75126769 [Test build #27731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27731/consoleFull) for PR 4695 at commit

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75134609 [Test build #27731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27731/consoleFull) for PR 4695 at commit

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75134621 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75108945 [Test build #27726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27726/consoleFull) for PR 4695 at commit

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75108954 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75148777 [Test build #27742 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27742/consoleFull) for PR 4695 at commit

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75158360 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75178074 Merged into master and branch-1.3. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4695 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/4695 [SPARK-5900][MLLIB] make PIC and FPGrowth Java-friendly You can merge this pull request into a Git repository by running: $ git pull https://github.com/mengxr/spark SPARK-5900 Alternatively

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75101083 [Test build #27726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27726/consoleFull) for PR 4695 at commit

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75167973 I missed those issues before! LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75175889 [Test build #27758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27758/consoleFull) for PR 4695 at commit

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75158350 [Test build #27742 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27742/consoleFull) for PR 4695 at commit

[GitHub] spark pull request: [SPARK-5900][MLLIB] make PIC and FPGrowth Java...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4695#issuecomment-75167597 [Test build #27758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27758/consoleFull) for PR 4695 at commit