Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92594483
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92565573
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92565550
[Test build #30212 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30212/consoleFull)
for PR 5431 at commit
[`d19236d`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92552866
[Test build #30210 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30210/consoleFull)
for PR 5431 at commit
[`26ae2d7`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92552876
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92549813
[Test build #30212 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30212/consoleFull)
for PR 5431 at commit
[`d19236d`](https://githu
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92548691
LGTM once tests pass
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92544002
[Test build #30210 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30210/consoleFull)
for PR 5431 at commit
[`26ae2d7`](https://githu
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28291065
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28290995
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -55,58 +49,42 @@ class Param[T] (
*/
def ->(value: T): ParamPair[
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28290778
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -325,7 +379,7 @@ class ParamMap private[ml] (private val map:
mutable.Map[Param[An
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28290818
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Softwar
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28290695
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
/**
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28290532
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
/**
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28290414
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
/**
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28290419
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
/**
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28289791
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -55,58 +49,42 @@ class Param[T] (
*/
def ->(value: T): ParamPair[T]
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28289673
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -78,23 +81,42 @@ class ParamsSuite extends FunSuite {
}
t
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28289697
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -17,15 +17,16 @@
package org.apache.spark.ml.classificatio
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92513221
@mengxr I added minor comment but don't have major ones. That's it for now!
---
If your project is set up for it, you can reply to this email and have your
reply appea
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28283755
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Soft
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28283689
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -325,7 +379,7 @@ class ParamMap private[ml] (private val map:
mutable.Map[Param
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28283381
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28282819
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28282538
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -55,58 +49,42 @@ class Param[T] (
*/
def ->(value: T): ParamPair[
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28282519
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala ---
@@ -17,15 +17,16 @@
package org.apache.spark.ml.classifica
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28282554
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28282550
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
@@ -179,52 +179,96 @@ trait Params extends Identifiable with Serializable {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28282562
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28282559
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (A
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5431#discussion_r28282508
--- Diff: mllib/src/test/scala/org/apache/spark/ml/param/ParamsSuite.scala
---
@@ -78,23 +81,42 @@ class ParamsSuite extends FunSuite {
}
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92509721
Should this method in Params be made abstract?
```
def validate(paramMap: ParamMap): Unit = {}
```
I just realized we haven't been using it, and making it
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92255656
[Test build #30150 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30150/consoleFull)
for PR 5431 at commit
[`eec2264`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92255674
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5431#issuecomment-92230105
[Test build #30150 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30150/consoleFull)
for PR 5431 at commit
[`eec2264`](https://githu
36 matches
Mail list logo
