Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85159896
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85159885
[Test build #29012 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29012/consoleFull)
for PR 4859 at commit
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4859#discussion_r26973738
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRelation.scala ---
@@ -111,17 +113,20 @@ private[sql] class DefaultSource extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4859#discussion_r26973668
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRelation.scala ---
@@ -111,17 +113,20 @@ private[sql] class DefaultSource extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4859#discussion_r26975414
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRelation.scala ---
@@ -115,18 +116,21 @@ private[sql] class DefaultSource extends
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85177123
One minor comment otherwise LGTM, provided documentation and a programatic
interface are added in a follow-up PR.
---
If your project is set up for it, you can reply
Github user vlyubin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4859#discussion_r26986539
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRelation.scala ---
@@ -115,18 +116,21 @@ private[sql] class DefaultSource extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85228515
[Test build #29032 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29032/consoleFull)
for PR 4859 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85129177
[Test build #29012 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29012/consoleFull)
for PR 4859 at commit
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85131353
This LGTM, we'll merge this and later add a jdbc() version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85247197
[Test build #29032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29032/consoleFull)
for PR 4859 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85247207
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4859
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-85253686
Thanks! Merged to master and branch-1.3.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/4859#discussion_r25719272
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRelation.scala ---
@@ -111,17 +113,20 @@ private[sql] class DefaultSource extends
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-77020949
I think it would also be reasonable to add to the SQLContext#jdbc() methods
a parameter for `options: Map[String, String]` like was done for
createExternalTable. This
GitHub user vlyubin opened a pull request:
https://github.com/apache/spark/pull/4859
[SPARK-6124] Support jdbc connection properties in OPTIONS part of the query
One more thing if this PR is considered to be OK - it might make sense to
add extra .jdbc() API's that take Properties
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-76870366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-76870357
[Test build #28202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28202/consoleFull)
for PR 4859 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-76859093
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-76861076
[Test build #28202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28202/consoleFull)
for PR 4859 at commit
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/4859#issuecomment-76860365
Jenkins, add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
22 matches
Mail list logo
