Github user haiyangsea closed the pull request at:
https://github.com/apache/spark/pull/4939
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/4939#discussion_r26457120
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQlDialect.scala ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user haiyangsea commented on a diff in the pull request:
https://github.com/apache/spark/pull/4939#discussion_r26458719
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQlDialect.scala ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/4939#discussion_r26274656
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQlDialect.scala ---
@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user haiyangsea commented on a diff in the pull request:
https://github.com/apache/spark/pull/4939#discussion_r26028022
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -208,6 +209,87 @@ case class DescribeCommand(
}
/**
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/4939#discussion_r26026592
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -20,6 +20,8 @@ package org.apache.spark.sql
import java.beans.Introspector
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/4939#discussion_r26026716
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
@@ -208,6 +209,87 @@ case class DescribeCommand(
}
/**
+
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/4939#issuecomment-77833714
just some minor comment, this looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user haiyangsea commented on the pull request:
https://github.com/apache/spark/pull/4939#issuecomment-77987697
/cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/4939#issuecomment-77736075
It might be simpler to just accept a dialect via a configuration option. Is
the idea here that someone might switch dialects multiple times in a single
session?
---
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4939#issuecomment-77733713
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user haiyangsea opened a pull request:
https://github.com/apache/spark/pull/4939
[SPARK-6200] [SQL] Add a manager for dialects
This PR added an independent dialect manager.
support sql statement to manage dialect:
SHOW [EXTENDED] DIALECT - show dialect name
12 matches
Mail list logo
