Github user jongyoul commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-83276749
@dragos Yes, right. I'll make `TaskState.isFailed` method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-83150238
@jongyoul thanks for pointing out. `TASK_LOST` is already handled
[here](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/cluster/
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-83097953
OK sounds good, let me know if there are other instances of this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user jongyoul commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-83027537
@srowen Two missing points remains. We should handle
`MesosTaskState.TASK_LOST` in `MesosSchedulerBackend` and
`CoarseMesosSchedulerBackend`. I will follow up this with
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5000
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-82964841
LGTM. That's a nice refactoring too to remove the 3x duplication of the
'finished' logic.
---
If your project is set up for it, you can reply to this email and have your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-82543825
[Test build #28731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28731/consoleFull)
for PR 5000 at commit
[`e063627`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-82543884
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-82498799
[Test build #28731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28731/consoleFull)
for PR 5000 at commit
[`e063627`](https://githu
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-82497407
Ok, it was faster than I thought. Please have a look at the last commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-82398326
Yes, but I'm not sure I can do it before Scala Days is over. Feel free to
close this and I'll reopen if you will.
BTW, I have a couple other pull requests that ar
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-82289813
@dragos are you able to make the other changes here? looks like a simple
additional change we could get in.
---
If your project is set up for it, you can reply to this em
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-79251406
Thanks for the pointer, I'll have a look in Mesos scheduler backends.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78985893
Agree, I think `TASK_ERROR` could also be considered a 'finished' state in
`MesosSchedulerBackend` and `CoarseMesosSchedulerBackend`
---
If your project is set up for it,
Github user jongyoul commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78759592
@dragos You will find more codes which you could fix in *SchedulerBackend
which handles MesosTaskState directly.
---
If your project is set up for it, you can reply to
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78655984
LGTM given the JIRA discussion and approval from @jongyoul
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78557395
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78557372
[Test build #28517 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28517/consoleFull)
for PR 5000 at commit
[`ac17cf0`](https://gith
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78528486
[Test build #28517 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28517/consoleFull)
for PR 5000 at commit
[`ac17cf0`](https://githu
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78527625
Add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78527572
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5000#issuecomment-78526740
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
GitHub user dragos opened a pull request:
https://github.com/apache/spark/pull/5000
[SPARK-6286][minor] Handle missing Mesos case TASK_ERROR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dragos/spark issue/task-error-case
Alt
23 matches
Mail list logo
