[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-09 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-91168539 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-91125785 Great LTM - @WangTaoTheTonic does that look okay to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-08 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-91092834 I have same question as Patrick too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-08 Thread parente
Github user parente commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-91116274 @pwendell @WangTaoTheTonic Good catch. I misconnected the upper line. It was not intentional. I've updated the PR with the diagram fix. --- If your project is

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-91055834 LGTM; this is a nice improvement over the old diagram. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-91088355 Great to have an improvement here. One thing I don't understand, there are two curved arrows from the SparkContext to the Executors/Workers. However, in the upper arrow

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-07 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-90514226 LGTM. What do you think @mateiz @pwendell @rxin ? Also you don't need to include a PPTX file. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-07 Thread parente
Github user parente commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-90525671 The original diagram source is in the `docs/img/` folder already. https://github.com/apache/spark/blob/master/docs/img/cluster-overview.pptx Would you

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-07 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-90528122 Oh I looked past that since it looked like a new file in Github. Yes leave it. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-06 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5382#issuecomment-90331681 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6343] Doc driver-worker network reqs

2015-04-06 Thread parente
GitHub user parente opened a pull request: https://github.com/apache/spark/pull/5382 [SPARK-6343] Doc driver-worker network reqs Attempt at making the driver-worker networking requirement more explicit and up-front in the documentation (see