[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-12-21 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-166268307 @marmbrus @maropu @gatorsmile I've update my PR to add CNFNormalization into the Optimizer. I'm so sorry for the delay in my reply. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-12-21 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r48133669 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -489,13 +511,13 @@ object BooleanSimplification extends

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-12-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-166266451 **[Test build #48111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48111/consoleFull)** for PR 8200 at commit [`7eebf6d`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-12-20 Thread maropu
Github user maropu commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-166213204 @gatorsmile +1 and great work :)) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-12-20 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-166212614 It sounds like multiple PRs are blocked by this PR. I will submit a PR for fixing it tomorrow. Thanks! --- If your project is set up for it, you can reply to this em

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-12-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-165831737 As discussed in another PR https://github.com/apache/spark/pull/10362, we plan to add CNF normalization into the Optimizer. Will you do it? Otherwise, I can do it. Th

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-16 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140836783 I don't think that is true. Its pretty standard to convert predicates into CNF as part of optimization: http://db.cs.berkeley.edu/papers/UCB-MS-zfong.pdf --- If your

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-15 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140610959 @marmbrus converting a filter into CNF may lead to an expanded filter, which I think is not necessarily a general optimisation. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-15 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140557486 Is there a reason to not do all of this in the optimizer? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140072659 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140072277 [Test build #42422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42422/console) for PR 8200 at commit [`9dc64e6`](https://github.

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140072656 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140043099 [Test build #42422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42422/consoleFull) for PR 8200 at commit [`9dc64e6`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140041697 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140041720 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-09-14 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-140010260 Since #5700 has been merged, I would revert the PR to its original version, without De Morgan's laws --- If your project is set up for it, you can reply to this email an

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-21 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-133324454 @liancheng , is the current version OK to you? seems you didn't see the updates. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132439851 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132439852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132439795 [Test build #41193 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41193/console) for PR 8200 at commit [`5c8e3db`](https://github.

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132413839 [Test build #41193 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41193/consoleFull) for PR 8200 at commit [`5c8e3db`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132412166 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132412159 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132193064 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132193022 [Test build #41125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41125/console) for PR 8200 at commit [`b78105d`](https://github.

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132193061 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132188195 [Test build #41125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41125/consoleFull) for PR 8200 at commit [`b78105d`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132187157 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132187142 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132187082 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132125460 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132125415 [Test build #41112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41112/console) for PR 8200 at commit [`b78105d`](https://github.

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132125462 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132120993 [Test build #41112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41112/consoleFull) for PR 8200 at commit [`b78105d`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132119819 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132119831 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132119747 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132118237 [Test build #41106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41106/console) for PR 8200 at commit [`b78105d`](https://github.

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132118271 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132118268 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132111886 [Test build #41106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41106/consoleFull) for PR 8200 at commit [`b78105d`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132109756 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132109810 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132063076 Ah got it! Thanks for the explanation :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-132056044 @cloud-fan Conjunctions (`And` predicates) are more friendlier to filter push-down optimization. Because it doesn't require both branches to be convertible. Take predi

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131873863 I'm new to data source, can someone explain what can we benefit from CNF? I'm sorry if this question is too stupid... --- If your project is set up for it, you can re

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-17 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37197618 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -501,6 +501,10 @@ object BooleanSimplification ex

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-17 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37179224 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -501,6 +501,10 @@ object BooleanSimplification extends

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-17 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37179117 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -501,6 +501,10 @@ object BooleanSimplification extends

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-16 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37159502 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -501,6 +501,10 @@ object BooleanSimplification ex

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-16 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37155062 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -501,6 +501,10 @@ object BooleanSimplification extends Ru

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-16 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37154582 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -501,6 +501,10 @@ object BooleanSimplification ex

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-16 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131649820 @liancheng, do you mind to review this again? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131230809 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131230811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131230509 [Test build #40897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40897/console) for PR 8200 at commit [`3d7fc52`](https://github.

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131197278 [Test build #40897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40897/consoleFull) for PR 8200 at commit [`3d7fc52`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131196178 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131196146 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37095602 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37084268 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37083782 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37083539 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37083284 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37083228 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37082793 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37082551 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37082316 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37082161 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37081863 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37081536 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37081428 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37081039 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37080783 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131119885 Thanks @liancheng , I will update my PR soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131119457 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131119259 [Test build #40873 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40873/console) for PR 8200 at commit [`c00f3a3`](https://github.

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37078760 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
Github user yjshen commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37078486 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37077029 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CNFNormalizationSuite.scala --- @@ -0,0 +1,120 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37076618 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37076313 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/8200#discussion_r37075991 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -59,6 +59,30 @@ trait PredicateHelper { }

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/8193#issuecomment-131106600 Hey @yjshen, I noticed that both this PR and #8132 are closed and code is cleaned. Seems to be misoperation? Your original PR branches still exist in your own repo tho

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131092359 [Test build #40873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40873/consoleFull) for PR 8200 at commit [`c00f3a3`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131091702 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8200#issuecomment-131091780 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
GitHub user yjshen opened a pull request: https://github.com/apache/spark/pull/8200 [SPARK-6624][SQL]Convert filters into CNF for data sources This PR aims at converting filters into CNF, i.e. AND of ORs. By doing this, we can possibly push more filters into datasource. For

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
Github user yjshen closed the pull request at: https://github.com/apache/spark/pull/8193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8193#issuecomment-131071292 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8193#issuecomment-131071034 [Test build #40856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40856/console) for PR 8193 at commit [`c00f3a3`](https://github.

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8193#issuecomment-131025562 [Test build #40856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40856/consoleFull) for PR 8193 at commit [`c00f3a3`](https://gith

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
Github user yjshen commented on the pull request: https://github.com/apache/spark/pull/8193#issuecomment-131024720 cc @rxin @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8193#issuecomment-131024240 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8193#issuecomment-131024082 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-6624][SQL]Convert filters into CNF for ...

2015-08-14 Thread yjshen
GitHub user yjshen opened a pull request: https://github.com/apache/spark/pull/8193 [SPARK-6624][SQL]Convert filters into CNF for data sources This PR aims at converting filters into CNF, i.e. AND of ORs. By doing this, we can possibly push more filters into datasource. For