[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-13 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-92457444 Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-13 Thread piaozhexiu
Github user piaozhexiu commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-92467104 Thank you @tgravescs ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/5321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-92441261 [Test build #30171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30171/consoleFull) for PR 5321 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-92441280 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-13 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-92412093 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-92412524 [Test build #30171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30171/consoleFull) for PR 5321 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-08 Thread piaozhexiu
Github user piaozhexiu commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-91027859 Thank you Sandy. I made the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-08 Thread tgravescs
Github user tgravescs commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-91034878 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-08 Thread piaozhexiu
Github user piaozhexiu commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-91033613 Jenkins failure seems due to a transient maven resolution error- ` sbt.ResolveException: unresolved dependency: org.apache.spark#spark-core_2.10;1.2.0: not

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-91028918 [Test build #29885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29885/consoleFull) for PR 5321 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-08 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-91030087 Thanks @piaozhexiu. This seems reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-91031734 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-91031722 [Test build #29885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29885/consoleFull) for PR 5321 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/5321#discussion_r27877884 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -21,14 +21,12 @@ import java.lang.reflect.Method import

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/5321#discussion_r27880090 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -201,6 +199,30 @@ class SparkHadoopUtil extends Logging { val

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/5321#discussion_r27881703 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -221,6 +221,7 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/5321#discussion_r27880984 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -201,6 +199,30 @@ class SparkHadoopUtil extends Logging { val

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-90715037 [Test build #29809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29809/consoleFull) for PR 5321 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-07 Thread piaozhexiu
Github user piaozhexiu commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-90714579 @tgravescs , thank you very much for the review! I incorporated all your comments, and please let me know if you have any more comments. --- If your project is set

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-90737814 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-90737806 [Test build #29809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29809/consoleFull) for PR 5321 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/5321#discussion_r27639338 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -93,6 +91,9 @@ class SparkHadoopUtil extends Logging { if

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-02 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-89132964 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-02 Thread piaozhexiu
Github user piaozhexiu commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-89067860 @tgravescs @srowen I just updated my patch that implementing Tom's suggestion- 1) The spark.yarn. properties are no longer copied into yarn configs. 2) A

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-89135426 [Test build #29640 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29640/consoleFull) for PR 5321 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-02 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-89156138 [Test build #29640 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29640/consoleFull) for PR 5321 at commit

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-89156160 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-01 Thread piaozhexiu
GitHub user piaozhexiu opened a pull request: https://github.com/apache/spark/pull/5321 [SPARK-6662][YARN] Allow variable substitution in spark.yarn.historyServer.address In Spark on YARN, explicit hostname and port number need to be set for spark.yarn.historyServer.address in

[GitHub] spark pull request: [SPARK-6662][YARN] Allow variable substitution...

2015-04-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5321#issuecomment-88671708 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your