Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9848
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158858117
LGTM. Merged into master and branch-1.6. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158577042
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158577045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158576981
**[Test build #46464 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46464/consoleFull)**
for PR 9848 at commit
[`ff54784`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158571866
**[Test build #46464 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46464/consoleFull)**
for PR 9848 at commit
[`ff54784`](https://gith
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158570982
OK, I believe that addressed everything. This includes a little
refactoring to make sure callers to the default metadata save/load methods are
using them correctly (a
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9848#discussion_r45530538
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -131,6 +137,181 @@ class CrossValidator(override val uid: String)
ext
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158545570
Made one pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9848#discussion_r45527888
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -131,6 +137,181 @@ class CrossValidator(override val uid: String)
extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9848#discussion_r45527882
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -131,6 +137,181 @@ class CrossValidator(override val uid: String)
extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9848#discussion_r45527878
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -131,6 +137,181 @@ class CrossValidator(override val uid: String)
extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9848#discussion_r45527885
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -131,6 +137,181 @@ class CrossValidator(override val uid: String)
extend
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/9848#discussion_r45527879
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -131,6 +137,181 @@ class CrossValidator(override val uid: String)
extend
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158406894
LGTM for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/9848#discussion_r45468030
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala ---
@@ -18,17 +18,23 @@
package org.apache.spark.ml.tuning
i
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158294477
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158294479
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158294405
**[Test build #46394 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46394/consoleFull)**
for PR 9848 at commit
[`1a29f23`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158284548
**[Test build #46394 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46394/consoleFull)**
for PR 9848 at commit
[`1a29f23`](https://gith
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9848#issuecomment-158283462
@mengxr @yanboliang Ready for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
21 matches
Mail list logo
