Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r29122071
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala ---
@@ -688,7 +688,7 @@ class ParquetDataSourceOnSourceSuite extends
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-96494320
That one actually doesn't handle most self join cases, since very often in
self joins you join on different keys.
---
If your project is set up for it, you can reply to
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-96492437
As https://github.com/apache/spark/pull/5638 handled self join correctly,
should we reopen this PR?
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-92635498
[Test build #30221 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30221/consoleFull)
for PR 5505 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-92664731
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-92664670
[Test build #30221 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30221/consoleFull)
for PR 5505 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-92671839
[Test build #30227 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30227/consoleFull)
for PR 5505 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r28302683
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -121,7 +121,7 @@ class DataFrameSuite extends QueryTest {
)
}
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/5505
[SPARK-6865][SQL] DataFrame column names should be treated as string
literals
For example, a.b should match a column named `a.b`.
You can merge this pull request into a Git repository by running:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r28304919
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala ---
@@ -688,7 +688,7 @@ class ParquetDataSourceOnSourceSuite extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-92700931
[Test build #30227 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30227/consoleFull)
for PR 5505 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r28305663
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -117,6 +117,15 @@ abstract class LogicalPlan
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r28306051
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -117,6 +117,15 @@ abstract class LogicalPlan extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-92700970
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r28306610
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -117,6 +117,15 @@ abstract class LogicalPlan
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r28307206
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -117,6 +117,15 @@ abstract class LogicalPlan extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r28349026
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -117,6 +117,15 @@ abstract class LogicalPlan
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5505#discussion_r28348897
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -121,7 +121,7 @@ class DataFrameSuite extends QueryTest {
)
Github user rxin closed the pull request at:
https://github.com/apache/spark/pull/5505
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5505#issuecomment-93182797
I discussed with michael offline -- given this would break self-join, we've
decided to treat [dot] (i.e. .) as a special case.
---
If your project is set up for it, you
20 matches
Mail list logo
