Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-93550520
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-93528614
[Test build #30357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30357/consoleFull)
for PR 5499 at commit
[`84cba38`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-93528652
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-93491077
[Test build #30357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30357/consoleFull)
for PR 5499 at commit
[`84cba38`](https://githu
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-93123075
Good catch! The change LGTM.
`NullableColumnBuilderSuite` uses a mock builder because the real builders
also mix in `CompressibleColumnBuilder`, while `Nullable
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-93120923
I will add a test in `InMemoryColumnarQuerySuite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-92537454
[Test build #30199 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30199/consoleFull)
for PR 5499 at commit
[`d169d33`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-92537484
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-92515941
@liancheng Where should I add the test? At first, I thought
`NullableColumnBuilderSuite` is the place But, why `NullableColumnBuilderSuite`
does not really use those real c
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5499#issuecomment-92515928
[Test build #30199 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30199/consoleFull)
for PR 5499 at commit
[`d169d33`](https://githu
GitHub user yhuai opened a pull request:
https://github.com/apache/spark/pull/5499
[SPARK-6887][SQL] ColumnBuilder misses FloatType
https://issues.apache.org/jira/browse/SPARK-6887
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/
12 matches
Mail list logo