[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122033190 [Test build #37513 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37513/console) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122033321 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7342 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122036492 [Test build #37516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37516/console) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122036596 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread yijieshen
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122036783 @yhuai, Thanks for the step by step guide, really appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122024064 Thanks for the update! LGTM. I will merge it to master once jenkins passes. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122010972 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122010922 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122012336 [Test build #37516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37516/consoleFull) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122009745 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122009776 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-16 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-122010072 [Test build #37513 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37513/consoleFull) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121699323 [Test build #37394 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37394/consoleFull) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121694806 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121703464 Looks good. Left a few comments about the test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121696877 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121696834 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34711225 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -761,4 +761,43 @@ class DataFrameSuite extends QueryTest {

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34711152 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -761,4 +761,43 @@ class DataFrameSuite extends QueryTest {

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121727075 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121726976 [Test build #37394 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37394/console) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-15 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34711294 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -761,4 +761,43 @@ class DataFrameSuite extends QueryTest {

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread yijieshen
Github user yijieshen commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34557250 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/rules.scala --- @@ -119,6 +120,10 @@ private[sql] case class PreWriteCheck(catalog:

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121202362 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121277498 [Test build #37225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37225/consoleFull) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121276405 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121304610 [Test build #37225 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37225/console) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121304863 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34641342 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -17,13 +17,14 @@ package org.apache.spark.sql +import

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121468117 [Test build #37303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37303/consoleFull) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121468005 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121468016 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121481860 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-14 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121481846 [Test build #37303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37303/console) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-121070474 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120830549 [Test build #1052 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1052/consoleFull) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120848182 [Test build #1052 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1052/console) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34430750 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/rules.scala --- @@ -119,6 +120,10 @@ private[sql] case class PreWriteCheck(catalog: Catalog)

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34430766 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/rules.scala --- @@ -119,6 +120,10 @@ private[sql] case class PreWriteCheck(catalog: Catalog)

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34430745 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/rules.scala --- @@ -119,6 +120,10 @@ private[sql] case class PreWriteCheck(catalog: Catalog)

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread yijieshen
Github user yijieshen commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34430902 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/rules.scala --- @@ -119,6 +120,10 @@ private[sql] case class PreWriteCheck(catalog:

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-12079 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120795678 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120795801 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120796451 [Test build #37119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37119/consoleFull) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/7342#discussion_r34431474 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/rules.scala --- @@ -119,6 +120,10 @@ private[sql] case class PreWriteCheck(catalog: Catalog)

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120813233 [Test build #37119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37119/console) for PR 7342 at commit

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120813246 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-12 Thread yijieshen
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120739848 thanks, I would update my implementation :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120249687 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-10 Thread yijieshen
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120251015 @yhuai it seems not possible to do checking in `CheckAnalysis` because LogicalRelation or LogicalRDD is not accessible there. Any ideas? --- If your project is set

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-10 Thread yijieshen
GitHub user yijieshen opened a pull request: https://github.com/apache/spark/pull/7342 [SPARK-6941][SQL] Provide a better error message to when inserting into RDD based table JIRA: https://issues.apache.org/jira/browse/SPARK-6941 You can merge this pull request into a Git

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-10 Thread yijieshen
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120435667 @rxin, do you mind also reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-6941][SQL] Provide a better error messa...

2015-07-10 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/7342#issuecomment-120480480 You can put it in `org.apache.spark.sql.sources.PreWriteCheck` (it is a `extendedCheckRules` configured in SQLContext and HiveContext), which is located in sql/core.