[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread chenghao-intel
Github user chenghao-intel closed the pull request at: https://github.com/apache/spark/pull/6104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-104445146 Actually I will submit a PR against your branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-104387588 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-104387586 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-104387559 [Test build #33254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33254/consoleFull) for PR 6104 at commit [`d625a64`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30827288 --- Diff: sql/hive/src/test/java/org/apache/spark/sql/hive/JavaDataFrameSuite.java --- @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30827249 --- Diff: sql/hive/src/test/java/org/apache/spark/sql/hive/JavaDataFrameSuite.java --- @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30826509 --- Diff: sql/hive/src/test/java/org/apache/spark/sql/hive/JavaDataFrameSuite.java --- @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30825871 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Window.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30825693 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Window.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30825654 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Window.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30825593 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Window.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30825618 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Window.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30824995 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Window.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-104361358 [Test build #33254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33254/consoleFull) for PR 6104 at commit [`d625a64`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30824246 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Window.scala --- @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30824198 --- Diff: sql/hive/src/test/java/org/apache/spark/sql/hive/JavaDataFrameSuite.java --- @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-104360261 @rxin Updated! But still need to add `scaladoc`, before I doing this, can you review the interface again? --- If your project is set up for it, you can repl

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-104360416 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-104360376 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-20 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103804810 +1 for a window function as i suggest above --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103801621 Ok toColumn - I think it'd make sense to just add a "window" function that creates a new WindowFunctionSpec, and then follow my original API design for the WindowFunctionSp

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-20 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103800518 @chenghao-intel I'm really confused. Why don't you just follow the API I wrote on SPARK-7322? It pollutes the namespace much less (no need to add orderby, partitionby to fu

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103338811 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103338813 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103338799 [Test build #33047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33047/consoleFull) for PR 6104 at commit [`06a29b8`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30569160 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -291,6 +291,269 @@ object functions { def max(columnName: String): Column = m

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30568983 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,372 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30568519 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,372 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30568419 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -291,6 +291,269 @@ object functions { def max(columnName: String):

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30567233 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30567024 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30566922 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,372 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30566606 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -291,6 +291,269 @@ object functions { def max(columnName: String): Column = m

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103313786 Thank you @scwf for reviewing this, I've updated the code to hide the properties of the `WindowFunctionDefinition`, and for giving a better name instead of the `W

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103313630 [Test build #33047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33047/consoleFull) for PR 6104 at commit [`06a29b8`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103313514 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103313530 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30564975 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -291,6 +291,269 @@ object functions { def max(columnName: String):

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30564674 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30564645 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30564615 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30564605 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Soft

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30563451 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30563276 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30563125 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30563029 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,341 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30562926 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -291,6 +291,269 @@ object functions { def max(columnName: String): Column = m

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103286602 @rxin, how about merge this PR first if you feel the API looks good? And I or someone else can add the python APIs in another PR, (I am not familiar with Python,

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread ogirardot
Github user ogirardot commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-103172055 Is it possible to merge this for 1.4 ? I'd really need this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102974323 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102974241 [Test build #32974 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32974/consoleFull) for PR 6104 at commit [`3dc8d09`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102974333 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102952684 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102952682 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102952648 [Test build #32969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32969/consoleFull) for PR 6104 at commit [`4553993`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102937501 [Test build #32974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32974/consoleFull) for PR 6104 at commit [`3dc8d09`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102937320 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102937305 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102928275 [Test build #32969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32969/consoleFull) for PR 6104 at commit [`4553993`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102928135 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102928142 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102822253 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102822254 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102822247 [Test build #32939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32939/consoleFull) for PR 6104 at commit [`dab001a`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102820902 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102820903 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102820900 [Test build #32938 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32938/consoleFull) for PR 6104 at commit [`58fb7f9`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102820006 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102820007 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102819992 [Test build #32937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32937/consoleFull) for PR 6104 at commit [`c76d5b5`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102811289 [Test build #32939 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32939/consoleFull) for PR 6104 at commit [`dab001a`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102810879 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102810850 Thank you @scwf I've updated the code to hide the `.toColumn`, and also fix the bug of specifying the `FrameType` --- If your project is set up for it, you can r

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102810874 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102810456 [Test build #32938 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32938/consoleFull) for PR 6104 at commit [`58fb7f9`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102809816 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102809768 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102808081 [Test build #32937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32937/consoleFull) for PR 6104 at commit [`c76d5b5`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102807805 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102807810 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-16 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/6104#discussion_r30460024 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/WindowFunctionDefinition.scala --- @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Found

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-16 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102600214 i think the `over` method of Column should also return `Column`, just like other methods of Column. So i suggest the api is more like this: ``` df.select(

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-16 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102592274 Let me think about it. The toColumn at the end is very ugly... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102458053 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102458056 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102458042 [Test build #32831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32831/consoleFull) for PR 6104 at commit [`523bf9a`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102423128 [Test build #32831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32831/consoleFull) for PR 6104 at commit [`523bf9a`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102422315 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102422240 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102421362 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102421348 [Test build #32829 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32829/consoleFull) for PR 6104 at commit [`0d745f5`](https://git

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102421359 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102420438 [Test build #32829 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32829/consoleFull) for PR 6104 at commit [`0d745f5`](https://gith

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102419989 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102419958 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102416276 @rxin @yhuai , any comments on the API design? Then I can start the rest of the work. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102416301 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102416305 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32

[GitHub] spark pull request: [SPARK-7322] [SQL] [WIP] Support Window Functi...

2015-05-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6104#issuecomment-102416298 [Test build #32827 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32827/consoleFull) for PR 6104 at commit [`a4da7fe`](https://git

  1   2   >