Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-167650817
Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166644466
**[Test build #48200 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48200/consoleFull)**
for PR 10174 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166670601
**[Test build #48200 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48200/consoleFull)**
for PR 10174 at commit
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48229826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48229820
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48229813
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -69,6 +71,13 @@ object DefaultOptimizer extends
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48229791
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerExtendableSuite.scala
---
@@ -0,0 +1,54 @@
+/*
+ *
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166560077
**[Test build #48175 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48175/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166560115
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166560116
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166551520
**[Test build #48175 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48175/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166670760
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166670758
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48183908
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -59,7 +59,7 @@ abstract class RuleExecutor[TreeType <:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48183993
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -69,6 +71,13 @@ object DefaultOptimizer extends
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48184082
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166264736
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166264544
**[Test build #48105 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48105/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166264734
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48212972
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerExtendableSuite.scala
---
@@ -0,0 +1,54 @@
+/*
+ *
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48212764
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -59,7 +59,7 @@ abstract class RuleExecutor[TreeType
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48212866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48127360
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -59,7 +59,7 @@ abstract class RuleExecutor[TreeType
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-166240691
**[Test build #48105 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48105/consoleFull)**
for PR 10174 at commit
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48126327
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,44 +28,53 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48127163
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48127180
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48127321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -69,6 +71,13 @@ object DefaultOptimizer extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48127272
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,11 +28,13 @@ import
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-165764973
**[Test build #48002 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48002/consoleFull)**
for PR 10174 at commit
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48018543
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala
---
@@ -0,0 +1,45 @@
+/*
+ *
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-165769694
**[Test build #48004 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48004/consoleFull)**
for PR 10174 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-165779961
**[Test build #48002 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48002/consoleFull)**
for PR 10174 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-165788137
**[Test build #48004 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48004/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-165780069
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-165780067
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-165788266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r48047481
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -28,44 +28,53 @@ import
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-165788264
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47677958
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164695506
**[Test build #47721 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47721/consoleFull)**
for PR 10174 at commit
Github user stephankessler commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164682419
Just related, currently preparing appropriate documents to propose that to
the community! Keep you posted!
---
If your project is set up for it, you can reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164695702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164695698
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164785477
Thank you! Looking forward to reading your proposal! : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47581375
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47581335
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164402553
**[Test build #47648 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47648/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164402693
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164402695
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164675274
**[Test build #47721 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47721/consoleFull)**
for PR 10174 at commit
Github user 3ourroom commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164675412
NAVER - http://www.naver.com/
3ourr...@naver.com ëê» ë³´ë´ì ë©ì¼ ì´ ë¤ìê³¼ ê°ì ì´ì ë¡
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164676681
Just curious. Is this for your project presented in "The Pushdown of
Everything"?
---
If your project is set up for it, you can reply to this email and have your
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47472268
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala
---
@@ -0,0 +1,45 @@
+/*
+ *
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-164381751
**[Test build #47648 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47648/consoleFull)**
for PR 10174 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-163889311
**[Test build #47577 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47577/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-163889668
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-163889666
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47331692
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-163871707
**[Test build #47577 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47577/consoleFull)**
for PR 10174 at commit
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47329605
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala
---
@@ -0,0 +1,45 @@
+/*
+ *
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47270183
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/DefaultOptimizerExtendableSuite.scala
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-163179211
**[Test build #47425 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47425/consoleFull)**
for PR 10174 at commit
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47071677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -17,6 +17,8 @@
package
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47071770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -56,12 +55,16 @@ abstract class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-163199890
**[Test build #47425 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47425/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-163200019
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-163200018
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47090351
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/Strategy.scala
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache
Github user stephankessler commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r47097859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/Strategy.scala
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162888285
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162888281
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162890394
**[Test build #47337 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47337/consoleFull)**
for PR 10174 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162921419
**[Test build #47337 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47337/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162921640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162921638
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r46997515
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala
---
@@ -56,12 +55,16 @@ abstract class RuleExecutor[TreeType
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10174#discussion_r46997422
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -17,6 +17,8 @@
package
GitHub user stephankessler opened a pull request:
https://github.com/apache/spark/pull/10174
[SPARK-7727] [SQL] Avoid inner classes in RuleExecutor
Moved (case) classes Strategy, Once, FixedPoint and Batch to the companion
object. This is necessary if we want to have the Optimizer
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162534062
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162722926
**[Test build #47296 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47296/consoleFull)**
for PR 10174 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162729095
**[Test build #47296 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47296/consoleFull)**
for PR 10174 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162729172
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162729171
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10174#issuecomment-162719567
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
86 matches
Mail list logo