[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-148832943 Sure, no problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user BenFradet closed the pull request at: https://github.com/apache/spark/pull/7406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-148829060 Hey @BenFradet, would you mind closing this PR for now? While I think that we may eventually remove TestData, this PR is going to be really merge-conflict prone and I

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-132800518 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-132800513 [Test build #41284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41284/console) for PR 7406 at commit [`3a022ab`](https://github.

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-132800519 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-132799079 [Test build #41284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41284/consoleFull) for PR 7406 at commit [`3a022ab`](https://gith

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-132797464 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-132797413 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-132288239 @rxin @andrewor14 This patch doesnt really make sense with the introduction of [SQLTestData](https://github.com/apache/spark/blob/master/sql/core/src/test/scal

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-130209397 No it is better to have the data closer to the test cases. Right now for most test cases it is hard to know what the correct answers should be because the input data

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-130205837 Don't we want a common collection of test data shared among different tests? It helps reducing duplicate code. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-130205317 Actually it looks like @andrewor14's patch just moved TestData somewhere else to remove the singleton. Maybe we should still bring this one up to date once his merges ... :

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-130203693 @rxin Should I close this then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-130091102 Ok, thanks for keeping me in the loop. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-130084387 Thanks @BenFradet. Looks like @andrewor14 is working on this at the same time to also get rid of the singleton TestSQLContext in order for his own tests to pass. h

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-129526991 I have no idea why both of those tests ([this one](https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala#L151) and [

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-129263640 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-129263621 [Test build #40276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40276/console) for PR 7406 at commit [`2c96ada`](https://github.

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-129252741 [Test build #40276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40276/consoleFull) for PR 7406 at commit [`2c96ada`](https://gith

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-129250275 Build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-129250304 Build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-128514601 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-128514566 [Test build #40074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40074/console) for PR 7406 at commit [`7d47151`](https://github.

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-128507075 [Test build #40074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40074/consoleFull) for PR 7406 at commit [`7d47151`](https://gith

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-128505604 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-128505577 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-127400681 Yup, will do later in the week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-127400096 @BenFradet After we've cut the release branch for 1.5, it would be great to bring this up-to-date so we can merge it. Thanks! --- If your project is set up for it, you ca

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user BenFradet commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121699756 Sure, no problem. On 15 Jul 2015 8:05 pm, "Reynold Xin" wrote: > @BenFradet thanks for doing this. I think > this is fai

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121695403 @BenFradet thanks for doing this. I think this is fairly useful & important, but the best time to merge this is during our QA period for 1.5.0, i.e. in the first 2 weeks of

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121411378 [Test build #37274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37274/console) for PR 7406 at commit [`1635564`](https://github.

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121411402 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121405596 [Test build #37274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37274/consoleFull) for PR 7406 at commit [`1635564`](https://gith

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121405167 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121405184 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121404206 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121404197 [Test build #37271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37271/console) for PR 7406 at commit [`2ab06a4`](https://github.

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121403702 [Test build #37271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37271/consoleFull) for PR 7406 at commit [`2ab06a4`](https://gith

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121402778 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7406#issuecomment-121402800 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8115] [SQL] Remove TestData

GitHub user BenFradet opened a pull request: https://github.com/apache/spark/pull/7406 [SPARK-8115] [SQL] Remove TestData This PR aims to bring the test datasets closer to the test suites. You can merge this pull request into a Git repository by running: $ git pull https://gith