[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-113054219 Thanks. Merging in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-18 Thread yijieshen
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-113067087 Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112910402 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112910156 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112910383 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112911047 [Test build #35051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35051/consoleFull) for PR 6828 at commit

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112940276 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112940239 [Test build #35051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35051/console) for PR 6828 at commit

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread yijieshen
Github user yijieshen commented on a diff in the pull request: https://github.com/apache/spark/pull/6828#discussion_r32599952 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala --- @@ -62,9 +62,14 @@ case class

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6828#discussion_r32601130 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala --- @@ -62,9 +62,14 @@ case class

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread yijieshen
Github user yijieshen commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112682097 @chenghao-intel, yes, I've noticed `struct` `named_struct` when I'm implementing this and just wandering whether we should implement both. The previous test

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112692973 `named_struct` is not implemented in Spark SQL right? At least, it should be registered in `FunctionRegistry`. Of course we can leave it for the future. --- If

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-17 Thread yijieshen
Github user yijieshen commented on a diff in the pull request: https://github.com/apache/spark/pull/6828#discussion_r32602451 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala --- @@ -62,9 +62,14 @@ case class

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-16 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112662507 There are 2 Struct UDFs in Hive: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStruct.java (struct)

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-16 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-112663074 BTW that's would be great if you can add the `NamedStruct` support. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-16 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/6828#discussion_r32596894 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala --- @@ -62,9 +62,14 @@ case class

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6828#issuecomment-111984097 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8283][SQL] Resolve udf_struct test fail...

2015-06-15 Thread yijieshen
GitHub user yijieshen opened a pull request: https://github.com/apache/spark/pull/6828 [SPARK-8283][SQL] Resolve udf_struct test failure in HiveCompatibilitySuite This PR aimed to resolve udf_struct test failure in HiveCompatibilitySuite. Currently, this is done by loosening