Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-114374392
LGTM, merging this into master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6814
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113789820
[Test build #35362 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35362/console)
for PR 6814 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113789829
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113777818
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113777827
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32885075
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -286,6 +288,9 @@ object Decimal {
/** Maximum number of decimal
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113777922
[Test build #35362 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35362/consoleFull)
for PR 6814 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32869361
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/types/decimal/DecimalSuite.scala
---
@@ -162,4 +162,9 @@ class DecimalSuite extends SparkFunSuite
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32869329
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -286,6 +288,9 @@ object Decimal {
/** Maximum number of decimal
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113641763
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32869203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -137,9 +139,9 @@ final class Decimal extends Ordered[Decimal] with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113641669
[Test build #35308 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35308/console)
for PR 6814 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32881524
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -137,9 +139,9 @@ final class Decimal extends Ordered[Decimal] with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32881564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -286,6 +288,9 @@ object Decimal {
/** Maximum number of decimal
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32810151
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32847892
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32844941
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32847142
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32848497
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113594263
[Test build #35300 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35300/console)
for PR 6814 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32850052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113593267
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113593540
[Test build #35300 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35300/consoleFull)
for PR 6814 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113593225
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113594269
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113597204
The style error is from #3347.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113606161
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113606195
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113605727
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113606420
[Test build #35308 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35308/consoleFull)
for PR 6814 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6814#discussion_r32764893
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -261,7 +261,7 @@ final class Decimal extends Ordered[Decimal] with
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113260121
Hive doesn't actually support BigDecimals with precision above 38. Why did
you want to add these? It may be okay to add them, but I think the current code
works fine for
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113265946
@mateiz We use DECIMAL128 as the MathContext to create BigDecimal, which
has precision as 34, it's lower than 38 in Hive.
```
scala val d = Decimal(2L60, 38,
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-113267633
Ah, okay. We should make sure we do exactly the same thing as Hive -- it's
possible that Hive also uses this context internally.
---
If your project is set up for it,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-111807945
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-111808570
[Test build #34882 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34882/consoleFull)
for PR 6814 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-111808013
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-111815768
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/6814
[SPARK-8359][SQL] Fix incorrect decimal precision after multiplication
JIRA: https://issues.apache.org/jira/browse/SPARK-8359
You can merge this pull request into a Git repository by running:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6814#issuecomment-111815761
[Test build #34882 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34882/console)
for PR 6814 at commit
41 matches
Mail list logo
