Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6817
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130183601
Alright, merging into master 1.5.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130122938
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130122703
[Test build #40526 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40526/console)
for PR 6817 at commit
[`9f12fa6`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130120129
[Test build #1461 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1461/console)
for PR 6817 at commit
[`9f12fa6`](https://github
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130112604
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130112503
**[Test build #40509 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40509/console)**
for PR 6817 at commit
[`9f12fa6`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130091813
[Test build #40526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40526/consoleFull)
for PR 6817 at commit
[`9f12fa6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130091323
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130091348
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130090605
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130087929
[Test build #1461 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1461/consoleFull)
for PR 6817 at commit
[`9f12fa6`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130064450
[Test build #40509 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40509/consoleFull)
for PR 6817 at commit
[`9f12fa6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130063181
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130063065
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130061943
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130055977
**[Test build #40476 timed
out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40476/console)**
for PR 6817 at commit
[`9f12fa6`](https://github
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-130056113
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129980485
[Test build #40476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40476/consoleFull)
for PR 6817 at commit
[`9f12fa6`](https://gith
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129979877
Latest changes LGTM, will merge once tests pass. Thanks for your
persistence @XuTingjun
---
If your project is set up for it, you can reply to this email and have y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129979603
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129979555
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129979205
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user XuTingjun commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129747858
@andrewor14, I have tested it in the real cluster, it's ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129742721
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129741441
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129741373
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129545914
@XuTingjun yes I think that looks fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user XuTingjun commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129336529
Maybe we can change below code, right?
```
val numTasksScheduled = stageIdToTaskIndices(stageId).size
val numTasksTotal = stageIdToNumTasks.g
Github user XuTingjun commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-129287244
@andrewor14, I understand what you mean.
what I consider is that, if many stages run in parallel, just delete L606
may be not correct.
---
If your project is se
Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128922978
@andrewor14 Makes better sense to me. Thanks for the explanation, Andrew.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128922519
@XuTingjun The fix here is not correct because after all tasks have been
scheduled we keep asking for executors even though we don't need them. I would
just add back
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6817#discussion_r36575665
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -628,6 +621,13 @@ private[spark] class ExecutorAllocationManager(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6817#discussion_r36575654
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -599,15 +599,6 @@ private[spark] class ExecutorAllocationManager(
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/6817#discussion_r36541063
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -628,6 +621,13 @@ private[spark] class ExecutorAllocationManager(
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/6817#discussion_r36539846
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -599,15 +599,6 @@ private[spark] class ExecutorAllocationManager(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128662091
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128662016
[Test build #40160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40160/console)
for PR 6817 at commit
[`25734c1`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128623127
[Test build #40160 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40160/consoleFull)
for PR 6817 at commit
[`25734c1`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128622640
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128622613
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128498690
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128498557
[Test build #40049 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40049/console)
for PR 6817 at commit
[`4b2dd75`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128456086
[Test build #40049 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40049/consoleFull)
for PR 6817 at commit
[`4b2dd75`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128453878
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128453823
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/6817#issuecomment-128452346
retest this please, this is failing a test that was already fixed in
upstream
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6817#discussion_r36439560
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -628,6 +621,13 @@ private[spark] class ExecutorAllocationManager(
48 matches
Mail list logo
