Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114740080
[Test build #35636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35636/console)
for PR 6825 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114740100
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114774250
[Test build #955 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/955/console)
for PR 6825 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114741059
[Test build #955 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/955/consoleFull)
for PR 6825 at commit
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114741423
LGTM, the failed PySpark test is not related, merging this into master,
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r33119609
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -175,8 +175,10 @@ class CodeGenContext {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/6825
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114612866
@cloud-fan Now #6876 is merged, could you update this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114726230
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114726224
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-114726275
[Test build #35636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35636/consoleFull)
for PR 6825 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-113052909
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-113049620
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-113049606
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32656460
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -109,7 +109,7 @@ trait ExpressionEvalHelper
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32656297
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait ExpressionEvalHelper {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32661616
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -109,7 +109,7 @@ trait
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32656257
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -109,7 +109,7 @@ trait ExpressionEvalHelper
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112887650
[Test build #35045 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35045/console)
for PR 6825 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112887742
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112832574
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32636153
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112832531
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112839277
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112839240
[Test build #35044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35044/console)
for PR 6825 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32647979
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -109,7 +109,7 @@ trait
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112833916
[Test build #35044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35044/consoleFull)
for PR 6825 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32636034
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -123,24 +124,40 @@ class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112856764
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32641466
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -109,7 +109,7 @@ trait
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112856791
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112857482
[Test build #35045 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35045/consoleFull)
for PR 6825 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112484946
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112484812
[Test build #34987 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34987/console)
for PR 6825 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112452089
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112452197
[Test build #34987 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34987/consoleFull)
for PR 6825 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112452130
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32593557
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait ExpressionEvalHelper {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32593520
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -123,24 +123,54 @@ class
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32595486
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait ExpressionEvalHelper {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32595311
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111997343
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111997405
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32410987
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -356,15 +367,11 @@ case class MaxOf(left:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111989386
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112016874
[Test build #34933 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34933/console)
for PR 6825 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112016896
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111998049
[Test build #34933 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34933/consoleFull)
for PR 6825 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111990868
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111990866
[Test build #34923 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34923/console)
for PR 6825 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111990308
[Test build #34923 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/34923/consoleFull)
for PR 6825 at commit
Github user lianhuiwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32410564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -341,9 +341,20 @@ case class MaxOf(left:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32422035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -341,9 +341,20 @@ case class MaxOf(left:
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112081358
retest it please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-112266153
@cloud-fan There are some changes related to Max/Min in #6726 , is it
useful for you? It will be good if you could merge them here.
---
If your project is set up for
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/6825
[SPARK-8371][SQL] improve unit test for MaxOf and MinOf and fix bugs
a follow up of https://github.com/apache/spark/pull/6813
You can merge this pull request into a Git repository by running:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111974399
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/6825#issuecomment-111975457
cc @rxin @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32399462
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala
---
@@ -123,24 +123,50 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32399563
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
---
@@ -356,15 +367,11 @@ case class MaxOf(left:
60 matches
Mail list logo
