[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112927231 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112927192 [Test build #35049 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35049/console) for PR 6839 at commit [`f98728b`](https://github.

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112900896 Approach looks fine to me. Once you address the comments I'll merge this. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/6839#discussion_r32656910 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -70,6 +70,13 @@ private[ui] class RDDOperationCluster(val id: String

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/6839#discussion_r32656904 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -70,6 +70,13 @@ private[ui] class RDDOperationCluster(val id: String

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/6839#discussion_r32656672 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -70,6 +70,13 @@ private[ui] class RDDOperationCluster(val id: String

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/6839#discussion_r32656406 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -70,6 +70,13 @@ private[ui] class RDDOperationCluster(val id: String

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/6839#discussion_r32655781 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -70,6 +70,13 @@ private[ui] class RDDOperationCluster(val id: String

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112896107 [Test build #35049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35049/consoleFull) for PR 6839 at commit [`f98728b`](https://gith

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112895667 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112895459 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112895599 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-17 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112895403 Hi @XuTingjun can you update the title to something more specific: "RDDOperationGraph: getting cached nodes is slow" or something? --- If your project is set up f

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-16 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112469240 /cc @andrewor14 for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-16 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on a diff in the pull request: https://github.com/apache/spark/pull/6839#discussion_r32518242 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -70,6 +70,13 @@ private[ui] class RDDOperationCluster(val id: S

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-16 Thread XuTingjun
Github user XuTingjun commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112407985 Yeah, I think expand all nodes then filter every node, is slow and cost memory. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/6839#discussion_r32513468 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -70,6 +70,16 @@ private[ui] class RDDOperationCluster(val id: String, p

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-16 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/6839#discussion_r32513428 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -70,6 +70,16 @@ private[ui] class RDDOperationCluster(val id: String, p

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6839#issuecomment-112360016 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] spark pull request: [SPARK-8392] Improve the efficiency

2015-06-16 Thread XuTingjun
GitHub user XuTingjun opened a pull request: https://github.com/apache/spark/pull/6839 [SPARK-8392] Improve the efficiency def getAllNodes: Seq[RDDOperationNode] = { _childNodes ++ _childClusters.flatMap(_.childNodes) } when the _childClusters has so many nodes, the proc