[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116271563 LGTM. For data source API, I understand we need an efficient `buildScan` that return `RDD[InternalRow]` as `RDD[Row]`. But I'm still feel we should make

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116206108 (That test failure is my fault; already hotfixed) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116206133 [Test build #969 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/969/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116206173 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116206176 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116224980 [Test build #970 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/970/console) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116206071 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116206068 [Test build #35916 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35916/console) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116206104 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116229585 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116229646 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116230818 [Test build #35934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35934/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116208486 [Test build #970 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/970/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116208279 [Test build #969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/969/console) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116218119 [Test build #35921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35921/console) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116218156 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7003 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7003#discussion_r33423504 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlSerializer.scala --- @@ -43,6 +41,7 @@ private[sql] class SparkSqlSerializer(conf:

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7003#discussion_r33423021 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlSerializer.scala --- @@ -43,6 +41,7 @@ private[sql] class

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116288978 In order to reduce the conflicts, I'm merging this into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116254897 [Test build #35934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35934/console) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116254972 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7003#discussion_r33414717 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala --- @@ -19,14 +19,54 @@ package org.apache.spark.sql.catalyst

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116148896 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116148941 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116166766 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116166759 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116166791 [Test build #35908 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35908/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116149511 [Test build #35901 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35901/console) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116149449 [Test build #35901 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35901/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116149512 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116180573 [Test build #35908 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35908/console) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116180623 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116153800 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116153642 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116156176 [Test build #35903 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35903/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116177420 **[Test build #35903 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35903/console)** for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116177479 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116194960 [Test build #35916 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35916/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116194274 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-116194294 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115162902 **[Test build #35758 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35758/console)** for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115162935 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-25 Thread sujkh85
Github user sujkh85 commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115163032 NAVER - http://www.naver.com/ su...@naver.com 님께 보내신 메일 Re: [spark] [SPARK-8610] [SQL]

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115054549 [Test build #35740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35740/console) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115054560 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/7003 [SPARK-8610] [SQL] Separate Row and InternalRow (part 2) Currently, we use GenericRow both for Row and InternalRow, which is confusing because it could contain Scala type also Catalyst types.

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115046674 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115051464 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115051530 [Test build #35740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35740/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115051482 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115046659 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115076609 **[Test build #35737 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35737/console)** for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115076621 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115046796 [Test build #35737 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35737/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115113283 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115113270 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115113324 [Test build #35758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35758/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7003#discussion_r33224283 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala --- @@ -19,14 +19,54 @@ package org.apache.spark.sql.catalyst

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115104675 [Test build #960 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/960/consoleFull) for PR 7003 at commit

[GitHub] spark pull request: [SPARK-8610] [SQL] Separate Row and InternalRo...

2015-06-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7003#issuecomment-115106414 [Test build #960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/960/console) for PR 7003 at commit