Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-164965793
By the way, @reggert how is this related to SPARK-4514?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-164965667
Thanks, merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user reggert commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-164967910
@andrewor14 I included a couple lines to propagate the local properties
(from the thread that created the `ComplexFutureAction`) to each of the spawned
jobs (all but
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-164512853
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user reggert commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r47446916
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-164276707
**[Test build #47629 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47629/consoleFull)**
for PR 9264 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-164285868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-164285867
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-164285830
**[Test build #47629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47629/consoleFull)**
for PR 9264 at commit
Github user reggert commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r47322111
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r47322325
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r47192789
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r47190819
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r47192089
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite
Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r47193488
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite
Github user reggert commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r47117656
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r46861956
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user reggert commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r46909976
--- Diff:
core/src/test/scala/org/apache/spark/rdd/AsyncRDDActionsSuite.scala ---
@@ -197,4 +197,34 @@ class AsyncRDDActionsSuite extends SparkFunSuite with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/9264#discussion_r46867432
--- Diff: core/src/main/scala/org/apache/spark/rdd/AsyncRDDActions.scala ---
@@ -65,17 +64,23 @@ class AsyncRDDActions[T: ClassTag](self: RDD[T])
extends
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-162639094
@reggert sorry for the delay. LGTM except a nit for test. Thanks very much.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user reggert commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-162326651
All I want for Christmas is a code review. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user reggert commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-161528329
@zsxwing @JoshRosen I just want to make sure that you guys haven't
forgotten about this. I haven't heard anything in a week and a half.
---
If your project is set up
Github user reggert commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-160829564
Any feedback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-159088473
@zsxwing, could you take a look at this patch? I think you'd be a good
reviewer for this given your experience with similar patches in streaming.
---
If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-158817738
**[Test build #46499 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46499/consoleFull)**
for PR 9264 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-158817770
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-158817771
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-158817052
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-158817053
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-158817011
**[Test build #46498 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46498/consoleFull)**
for PR 9264 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9264#issuecomment-158801223
**[Test build #46499 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46499/consoleFull)**
for PR 9264 at commit
32 matches
Mail list logo
