[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140578273 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8676 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140607740 @rxin I reverted the patch that caused those. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140607734 I've merged this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140608496 It has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140578152 [Test build #42504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42504/console) for PR 8676 at commit

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140578275 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140607639 @vanzin do you know what's going on with the tests? [error] Execution of test test.org.apache.spark.sql.JavaApplySchemaSuite failed:

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140520067 Thanks. Merging this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140526528 [Test build #1760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1760/console) for PR 8676 at commit

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140519265 @rxin Thank you for reviewing the patch . Just to make sure tested with out the next() call on MySql, Postgres, and DB2, it worked fine. Updated the pull

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140520458 [Test build #1760 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1760/consoleFull) for PR 8676 at commit

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140520174 (Oops spoke too soon - I will merge after tests pass) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140545384 [Test build #42504 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42504/consoleFull) for PR 8676 at commit

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140541446 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140541508 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-15 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-140539473 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-11 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-139611398 next() will return false because resultset will be empty when query is where 1!=0. executeQuery() will throw an exception if table is not found. next() call

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-11 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-139611781 Typo in my previous comment, I meant when query is where 1=0. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8676#discussion_r39230872 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -42,10 +42,13 @@ object JdbcUtils extends Logging {

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8676#discussion_r39230841 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala --- @@ -88,6 +88,17 @@ abstract class JdbcDialect { def

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-10 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-139410536 @rxin Even if spark is running on jdk1.7, customers using older version of drivers will run into AbstractMethodError exception. I think adding

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-10 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/8676#discussion_r39227358 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala --- @@ -88,6 +88,17 @@ abstract class JdbcDialect { def

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-09 Thread sureshthalamati
GitHub user sureshthalamati opened a pull request: https://github.com/apache/spark/pull/8676 [SPARK-9078] [SQL] Allow jdbc dialects to override the query used to check the table. Current implementation uses query with a LIMIT clause to find if table already exists. This syntax

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-139097036 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9078] [SQL] Allow jdbc dialects to over...

2015-09-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/8676#issuecomment-139097004 FWIW, we dropped JVM 1.6 support in Spark 1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your