[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7697 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-08-02 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-127051469 @yu-iskw Thanks for adding this, and others for reviewing! It looks good. My only comment is that it might be good to use the built-in MLlib methods like

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-08-02 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-127092526 @srowen thank you for merging it! @jkbradley thank you for your feedback! I agree with that it would be better to use `MLUtils.loadVectors`. However, it

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-08-02 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-127105448 Ohh, I see. That's fine. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35861720 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-30 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-126282672 I think this is pretty fine, minus one thing I can fix on merge. Any more comments? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-126133450 [Test build #38919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38919/consoleFull) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-126139749 @techaddict thank you for your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-126133200 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-126133229 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-126136654 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35740850 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/KMeansExample.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35740783 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/KMeansExample.scala --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125866394 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125851738 LGTM pending tests; wouldn't hurt to have @jkbradley look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125852778 @srowen Thank you for reviewing it! @jkbradley Could you take a glance at this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125866318 [Test build #38807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38807/console) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-126136354 [Test build #38919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38919/console) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35619593 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/KMeansExample.scala --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125478031 @srowen I made examples in Scala and Java more simple. Could you review it? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35619640 --- Diff: examples/src/main/scala/org/apache/spark/examples/ml/KMeansExample.scala --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35619518 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35619529 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35619542 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35619559 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125849111 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125849122 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125849265 [Test build #38807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38807/consoleFull) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125226470 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125225163 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125227555 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125227612 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35547864 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35548056 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35548012 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125225198 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125236591 [Test build #38551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38551/console) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125226098 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125228083 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125227789 [Test build #115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/115/consoleFull) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125233978 [Test build #115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/115/console) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125234331 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/7697 [SPARK-9149][ML][Examples] Add an example of spark.ml KMeans [SPARK-9149] Add an example of spark.ml KMeans - ASF JIRA https://issues.apache.org/jira/browse/SPARK-9149 @jkbradley Should we

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125228153 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125229686 [Test build #38551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38551/consoleFull) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125236710 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35598240 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/7697#discussion_r35598247 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaKMeansExample.java --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125399245 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125401233 [Test build #38619 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38619/console) for PR 7697 at commit

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125401272 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125399260 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9149][ML][Examples] Add an example of s...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7697#issuecomment-125399716 [Test build #38619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38619/consoleFull) for PR 7697 at commit