[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35618757 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala --- @@ -78,13 +78,20 @@ class RFormula(override val uid: String) extends

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35618772 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35618774 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35618765 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35618780 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala --- @@ -32,8 +32,10 @@ private[r] object SparkRWrappers { alpha: Double):

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35618777 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala --- @@ -32,8 +32,10 @@ private[r] object SparkRWrappers { alpha: Double):

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35619074 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaParserSuite.scala --- @@ -32,4 +37,38 @@ class RFormulaParserSuite extends SparkFunSuite {

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35619029 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125484053 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620888 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620875 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala --- @@ -32,8 +32,10 @@ private[r] object SparkRWrappers { alpha: Double):

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620883 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620868 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaParserSuite.scala --- @@ -32,4 +37,38 @@ class RFormulaParserSuite extends SparkFunSuite {

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620892 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala --- @@ -78,13 +78,20 @@ class RFormula(override val uid: String) extends

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125483285 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620872 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125483266 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35618883 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620881 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/SparkRWrappers.scala --- @@ -32,8 +32,10 @@ private[r] object SparkRWrappers { alpha: Double):

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620870 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35620885 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125676071 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125676403 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125676771 LGTM except that we should filter column types in dot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125677474 [Test build #38720 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38720/consoleFull) for PR 7707 at commit

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125685268 [Test build #38720 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38720/console) for PR 7707 at commit

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125685386 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125676358 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7707#discussion_r35670466 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormulaParser.scala --- @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125693622 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread ericl
Github user ericl commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125690700 Updated to filter column types --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125712816 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125712888 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125722071 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125691920 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125691886 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125712391 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125732853 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125732875 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125732056 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125733181 [Test build #38756 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38756/consoleFull) for PR 7707 at commit

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125757656 Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125742538 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125742269 [Test build #38756 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38756/console) for PR 7707 at commit

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125396408 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125395023 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125394958 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread ericl
GitHub user ericl opened a pull request: https://github.com/apache/spark/pull/7707 [SPARK-9391] [ML] Support minus, dot, and intercept operators in SparkR RFormula Adds '.', '-', and intercept parsing to RFormula. Also splits RFormulaParser into a separate file. Umbrella

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125385590 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125385612 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125387183 [Test build #38612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38612/consoleFull) for PR 7707 at commit

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125398836 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9391] [ML] Support minus, dot, and inte...

2015-07-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7707#issuecomment-125398787 [Test build #38612 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38612/console) for PR 7707 at commit