Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-172986605
**[Test build #49707 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49707/consoleFull)**
for PR 10472 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-172999713
**[Test build #49707 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49707/consoleFull)**
for PR 10472 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-172986883
**[Test build #2411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2411/consoleFull)**
for PR 10472 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-17215
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-17216
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-173015481
Merging with master
Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-173000926
**[Test build #2411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2411/consoleFull)**
for PR 10472 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10472
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-172982448
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-172941376
No problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-172939069
LGTM. I'll re-run tests since it's been a little while though. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-171789681
**[Test build #49412 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49412/consoleFull)**
for PR 10472 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-17179
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-171790005
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-171779233
**[Test build #49412 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49412/consoleFull)**
for PR 10472 at commit
Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/10472#discussion_r49691297
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
---
@@ -29,6 +29,7 @@ import
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10472#discussion_r49679366
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
---
@@ -29,6 +29,7 @@ import
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-170924106
Ping @jkbradley, is that what you had in mind?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169836993
**[Test build #48977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48977/consoleFull)**
for PR 10472 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169837133
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169837135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169788073
**[Test build #48955 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48955/consoleFull)**
for PR 10472 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169818842
Thanks for the updates! I just thought of one more item: Could you please
update the class documentation (BinaryClassificationEvaluator.scala around line
31) to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169827261
**[Test build #48977 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48977/consoleFull)**
for PR 10472 at commit
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/10472#discussion_r48993085
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
---
@@ -79,13 +79,14 @@ class
Github user thunterdb commented on a diff in the pull request:
https://github.com/apache/spark/pull/10472#discussion_r48993376
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
---
@@ -44,6 +44,23 @@ private[spark] object SchemaUtils {
}
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169418377
@BenFradet thanks! Just a small comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10472#discussion_r49029265
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluatorSuite.scala
---
@@ -36,4 +37,35 @@ class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10472#discussion_r49029260
--- Diff: mllib/src/main/scala/org/apache/spark/ml/util/SchemaUtils.scala
---
@@ -44,6 +44,23 @@ private[spark] object SchemaUtils {
}
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169508852
Just a couple small comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user thunterdb commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169483754
cc @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169564256
@jkbradley Updated, thanks for your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169573908
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169453187
**[Test build #48870 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48870/consoleFull)**
for PR 10472 at commit
Github user BenFradet commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169442981
@thunterdb thanks for the review, will fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169464891
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169464880
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-169464364
**[Test build #48870 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48870/consoleFull)**
for PR 10472 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-167166797
**[Test build #48318 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48318/consoleFull)**
for PR 10472 at commit
GitHub user BenFradet opened a pull request:
https://github.com/apache/spark/pull/10472
[SPARK-9716] [ML] BinaryClassificationEvaluator should accept Double
prediction column
This PR aims to allow the prediction column of
`BinaryClassificationEvaluator` to be of double type.
You
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-167169467
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-167169466
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10472#issuecomment-167169451
**[Test build #48318 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48318/consoleFull)**
for PR 10472 at commit
43 matches
Mail list logo
