Github user flyjy commented on a diff in the pull request:
https://github.com/apache/spark/pull/8056#discussion_r52831393
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/ResolvedDataSource.scala
---
@@ -0,0 +1,204 @@
+/*
+* Licensed to the Apac
Github user v-gerasimov commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-146465118
Hi, @rxin!
It seems like something wrong when you try to add ```SQLTab``` to
```SparkUI.tabs```, doesn't
it?(https://github.com/apache/spark/blob/40ed2af587
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-131272818
@rama-mullapudi thanks. can you submit a patch to fix those?
I think I only moved the stuff around.
---
If your project is set up for it, you can reply to this em
Github user rama-mullapudi commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-131272280
jdbcutils scala code has a typo error in schemaString function, decimal
type has extra closing braces } which is causing create table with decimal fail
as create
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8056
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129602389
cc @liancheng for the change also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129602316
OK I'm going to merge this since it's from a flaky test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129601789
[Test build #40306 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40306/console)
for PR 8056 at commit
[`9df4801`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129601853
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129563191
[Test build #40306 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40306/consoleFull)
for PR 8056 at commit
[`9df4801`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129562642
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129562622
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129562326
Not intentional -- but not that big of a deal for them to be there since I
care more about the public API visibility here.
---
If your project is set up for it, you can r
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129376475
[Test build #1419 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1419/console)
for PR 8056 at commit
[`3dfc06c`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129333035
[Test build #1419 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1419/consoleFull)
for PR 8056 at commit
[`3dfc06c`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129325375
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129325350
[Test build #40283 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40283/console)
for PR 8056 at commit
[`3dfc06c`](https://github.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129294091
Is it intentional to keep `DDLSourceLoadSuite.scala` and
`ResolvedDataSourceSuite.scala` under `org.apache.spark.sql.sources`?
---
If your project is set up for it, you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129293133
[Test build #40283 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40283/consoleFull)
for PR 8056 at commit
[`3dfc06c`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129292116
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129292022
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129289529
The failure is because ParquetIOSuite has a hard-code name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129289188
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129289169
[Test build #40280 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40280/console)
for PR 8056 at commit
[`9d83ba2`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129269213
[Test build #40280 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40280/consoleFull)
for PR 8056 at commit
[`9d83ba2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129268812
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129268860
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129260711
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129260694
[Test build #40275 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40275/console)
for PR 8056 at commit
[`c3a4ba4`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129236835
[Test build #40275 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40275/consoleFull)
for PR 8056 at commit
[`c3a4ba4`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129236388
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129236381
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129222335
@zsxwing removed visible for testing tag.
We can move UI package around later -- it's also OK if it contains
non-execution stuff. Not that big of a deal...
---
I
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129192816
Although the SQL UI only displays the execution info now, moving the `ui`
package into the `execution` package looks not a good idea. I guess we may add
other informatio
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129150168
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129150161
[Test build #40263 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40263/console)
for PR 8056 at commit
[`8f4dc20`](https://github.
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129144774
@rxin could you help remove `@VisibleForTesting` from `SQLListener.scala`
because of the issue mentioned by @shivaram in
https://github.com/apache/spark/pull/7774#issuec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129129719
[Test build #40263 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40263/consoleFull)
for PR 8056 at commit
[`8f4dc20`](https://gith
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129129598
cc @zsxwing for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129129511
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129129513
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129102547
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129102507
[Test build #40259 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40259/console)
for PR 8056 at commit
[`122864a`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129101749
[Test build #40259 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40259/consoleFull)
for PR 8056 at commit
[`122864a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129101661
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129101487
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129101474
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129100283
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8056#issuecomment-129100278
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/8056
[SPARK-9763][SQL] Minimize exposure of internal SQL classes.
There are a few changes in this pull request:
1. Moved all data sources to execution.datasources, except the public JDBC
APIs.
50 matches
Mail list logo
