Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140353719
@mengxr OK, I opened
[SPARK-10615](https://issues.apache.org/jira/browse/SPARK-10615) to track the
```assertEquals``` to ```assertEqual``` issue. I will submit a PR i
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140278628
LGTM. Merged into master. @yanboliang `assertEquals` is deprecated. Could
you make a pass over existing unit tests and make a new PR that changes
`assertEquals` to `asser
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140267677
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140267676
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140267607
[Test build #42465 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42465/console)
for PR 8166 at commit
[`b58d1bb`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140262473
[Test build #42465 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42465/consoleFull)
for PR 8166 at commit
[`b58d1bb`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140262298
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140262305
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39417765
--- Diff: python/pyspark/mllib/tests.py ---
@@ -194,6 +194,37 @@ def test_squared_distance(self):
self.assertEquals(3.0, _squared_distance(sv, arr)
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39417597
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -122,6 +123,15 @@ def _format_float_list(l):
return [_format_float(x) for x in l]
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140031221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140031123
[Test build #42420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42420/console)
for PR 8166 at commit
[`3b8ac7a`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140031220
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140027998
[Test build #42420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42420/consoleFull)
for PR 8166 at commit
[`3b8ac7a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140027803
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-140027779
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-139438587
@yanboliang Please update the PR to use the first 128 nonzeros entries to
compute hash.
---
If your project is set up for it, you can reply to this email and have your
r
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39238213
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -404,11 +414,57 @@ def __repr__(self):
return "DenseVector([%s])" % (', '.join(_format_flo
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39238212
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -404,11 +414,57 @@ def __repr__(self):
return "DenseVector([%s])" % (', '.join(_format_flo
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39221680
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,42 @@ def parse(s):
def zeros(size):
return DenseVector(np.zeros(size
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39221085
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -739,6 +802,32 @@ def __getitem__(self, index):
def __ne__(self, other):
return n
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39220889
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -739,6 +802,32 @@ def __getitem__(self, index):
def __ne__(self, other):
return n
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39220538
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -404,11 +414,57 @@ def __repr__(self):
return "DenseVector([%s])" % (', '.join(_format_flo
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39220362
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -404,11 +414,57 @@ def __repr__(self):
return "DenseVector([%s])" % (', '.join(_format_flo
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39220301
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -404,11 +414,57 @@ def __repr__(self):
return "DenseVector([%s])" % (', '.join(_format_flo
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39220331
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -404,11 +414,57 @@ def __repr__(self):
return "DenseVector([%s])" % (', '.join(_format_flo
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r39220311
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -404,11 +414,57 @@ def __repr__(self):
return "DenseVector([%s])" % (', '.join(_format_flo
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-135282553
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-135282555
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-135282290
[Test build #41666 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41666/console)
for PR 8166 at commit
[`d63d54e`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-135277188
[Test build #41666 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41666/consoleFull)
for PR 8166 at commit
[`d63d54e`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-135273565
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-135273520
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-135113735
LGTM after docstring change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r38009024
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,41 @@ def parse(s):
def zeros(size):
return DenseVector(np.zero
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r38008775
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,41 @@ def parse(s):
def zeros(size):
return DenseVector(np.zero
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r37964626
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,41 @@ def parse(s):
def zeros(size):
return DenseVector(np.zeros(
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r37964470
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,41 @@ def parse(s):
def zeros(size):
return DenseVector(np.zeros(
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r37825336
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,41 @@ def parse(s):
def zeros(size):
return DenseVector(np.zero
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r37781815
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,41 @@ def parse(s):
def zeros(size):
return DenseVector(np.zero
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r37781102
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,41 @@ def parse(s):
def zeros(size):
return DenseVector(np.zero
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8166#discussion_r37781117
--- Diff: python/pyspark/mllib/linalg/__init__.py ---
@@ -841,6 +930,41 @@ def parse(s):
def zeros(size):
return DenseVector(np.zero
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131321794
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131321793
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131321769
[Test build #40949 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40949/console)
for PR 8166 at commit
[`2a85d09`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131319118
[Test build #40949 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40949/consoleFull)
for PR 8166 at commit
[`2a85d09`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131318855
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131318845
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131318862
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131317606
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131317607
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131316750
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-131316757
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-130727920
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-130727764
[Test build #40766 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40766/console)
for PR 8166 at commit
[`1b4ed66`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-130722714
[Test build #40766 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40766/consoleFull)
for PR 8166 at commit
[`1b4ed66`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-130721229
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8166#issuecomment-130721164
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/8166
[SPARK-9793] [MLlib] [PySpark] PySpark DenseVector, SparseVector __eq__
should use semantics
PySpark DenseVector, SparseVector `__eq__` method should use semantics
equality.
You can merge this
60 matches
Mail list logo