Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r8953
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -448,15 +448,24 @@ private[spark] object SQLConf {
defaultValue =
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9556
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155533284
We should keep reviewing and address any comments in a follow-up, but I'm
going to merge this now to unblock other work. Thanks!
---
If your project is set up for
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44451436
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Stddev.scala
---
@@ -48,29 +50,26 @@ abstract class
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r1047
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -120,14 +133,26 @@ trait CheckAnalysis {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r3426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -120,14 +133,26 @@ trait CheckAnalysis {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44451117
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala
---
@@ -29,16 +31,13 @@ case class Sum(child: Expression)
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44452030
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Stddev.scala
---
@@ -48,29 +50,26 @@ abstract class StddevAgg(child:
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r0725
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -525,21 +526,14 @@ class Analyzer(
case u @
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r0841
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -108,7 +109,19 @@ trait CheckAnalysis {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44451909
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala
---
@@ -55,13 +57,10 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44451806
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala
---
@@ -29,16 +31,13 @@ case class Sum(child: Expression)
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44454907
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -525,21 +526,14 @@ class Analyzer(
case u @
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44464801
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala
---
@@ -29,16 +31,13 @@ case class Sum(child: Expression)
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44464823
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CentralMomentAgg.scala
---
@@ -55,13 +57,10 @@ abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44464472
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -448,15 +448,24 @@ private[spark] object SQLConf {
defaultValue =
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44455980
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -108,7 +109,19 @@ trait CheckAnalysis {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44463726
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -120,14 +133,26 @@ trait CheckAnalysis {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44464815
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Stddev.scala
---
@@ -48,29 +50,26 @@ abstract class StddevAgg(child:
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44269743
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/WindowSpec.scala ---
@@ -141,40 +141,46 @@ class WindowSpec private[sql](
*/
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155054384
Made a quick pass. I think the PR is in good shape. I do have a few
aditional questions/remarks:
* Maybe should add some documentation to
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155263519
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44361205
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -53,6 +54,12 @@ object functions {
private def withExpr(expr:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44361789
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
@@ -448,15 +448,17 @@ private[spark] object SQLConf {
defaultValue =
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44366543
--- Diff: R/pkg/R/functions.R ---
@@ -1339,7 +1339,7 @@ setMethod("pmod", signature(y = "Column"),
#' @export
setMethod("approxCountDistinct",
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155290543
**[Test build #45476 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45476/consoleFull)**
for PR 9556 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155290683
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155290682
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155295488
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155295464
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155297593
**[Test build #45492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45492/consoleFull)**
for PR 9556 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44361188
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/WindowSpec.scala ---
@@ -141,40 +141,56 @@ class WindowSpec private[sql](
*/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155263282
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155263285
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155262404
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44360853
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Skewness.scala
---
@@ -24,6 +24,8 @@ case class Skewness(child:
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44360927
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Kurtosis.scala
---
@@ -24,6 +24,8 @@ case class Kurtosis(child:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155257980
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155257977
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155257913
**[Test build #45442 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45442/consoleFull)**
for PR 9556 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155258202
**[Test build #2024 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2024/consoleFull)**
for PR 9556 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155263092
**[Test build #45474 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45474/consoleFull)**
for PR 9556 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155264259
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155265613
**[Test build #45476 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45476/consoleFull)**
for PR 9556 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155286504
**[Test build #2027 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2027/consoleFull)**
for PR 9556 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44371174
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -141,6 +141,10 @@ case class UnresolvedFunction(
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44361592
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedData.scala ---
@@ -88,30 +89,33 @@ class GroupedData protected[sql](
namedExpr
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155130215
**[Test build #45380 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45380/consoleFull)**
for PR 9556 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155119555
**[Test build #45374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45374/consoleFull)**
for PR 9556 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44298295
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -146,148 +146,105 @@ private[sql] abstract class SparkStrategies
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155129634
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155141098
ok. I moved the rewriter and I added docs to `DeclarativeAggregate`
regarding why we need to use `lazy val`s.
---
If your project is set up for it, you can reply to this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155154504
**[Test build #45374 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45374/consoleFull)**
for PR 9556 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155154682
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155128490
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155122434
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44297570
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -146,148 +146,105 @@ private[sql] abstract class SparkStrategies
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155122470
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155129602
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155120739
I will `MultipleDistinctRewriter` to the package of
`org.apache.spark.sql.catalyst.analysis`.
---
If your project is set up for it, you can reply to this email and have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155118346
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155118316
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155128961
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155179635
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155179711
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155180027
I think one follow-up work is to add tests in `ExpressionTypeCheckingSuite`
to make sure those newly added agg functions (e.g. corr and variance) throw the
right
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155160189
**[Test build #45380 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45380/consoleFull)**
for PR 9556 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155160400
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155182875
**[Test build #45407 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45407/consoleFull)**
for PR 9556 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44327164
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -146,148 +146,105 @@ private[sql] abstract class SparkStrategies
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155348607
**[Test build #45492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45492/consoleFull)**
for PR 9556 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155348765
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155348763
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44374094
--- Diff: R/pkg/R/functions.R ---
@@ -1339,7 +1339,7 @@ setMethod("pmod", signature(y = "Column"),
#' @export
setMethod("approxCountDistinct",
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44361162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -141,6 +146,12 @@ sealed abstract class
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44363471
--- Diff: R/pkg/R/functions.R ---
@@ -1339,7 +1339,7 @@ setMethod("pmod", signature(y = "Column"),
#' @export
setMethod("approxCountDistinct",
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155262424
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155264239
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155264172
**[Test build #2027 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2027/consoleFull)**
for PR 9556 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155282013
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155223300
**[Test build #45407 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45407/consoleFull)**
for PR 9556 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155223396
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155225000
PySpark results are correct, just not in the correct form :(...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155224746
LGTM, pending a successful test build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155232483
**[Test build #2024 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2024/consoleFull)**
for PR 9556 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155232599
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155232567
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155226238
Yeah. I will change the prettyString of {{AggregateExpression}}. Also,
since I need to update anyway, I am including my change that introduces the
flag used by
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9556#issuecomment-155231775
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44355987
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -177,6 +178,7 @@ object FunctionRegistry {
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44355961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -108,7 +109,16 @@ trait CheckAnalysis {
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44350660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
@@ -272,7 +273,7 @@ object SqlParser extends AbstractSparkSQLParser
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44350703
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -525,21 +526,15 @@ class Analyzer(
case u
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44351730
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Kurtosis.scala
---
@@ -24,6 +24,8 @@ case class Kurtosis(child:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44351651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -55,6 +56,22 @@ case class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44351757
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Skewness.scala
---
@@ -24,6 +24,8 @@ case class Skewness(child:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44351704
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Kurtosis.scala
---
@@ -24,6 +24,8 @@ case class Kurtosis(child:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44351639
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Count.scala
---
@@ -32,23 +32,34 @@ case class Count(child:
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44351922
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala
---
@@ -141,6 +146,12 @@ sealed abstract class
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/9556#discussion_r44350995
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -108,7 +109,16 @@ trait CheckAnalysis {
1 - 100 of 132 matches
Mail list logo
