Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-135632197
Since all comments are minor (or beyond this PR), I'm going to merge this
into master and branch-1.5 first and then send another PR to fix issues here
and some others.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-135630153
@MechCoder is busy this week. I will make a PR based on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-134721887
+1 for "moving the example and providing some guidance about how to choose
evaluators/validators"
Something simple, but separate, which we can build upon later
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-134236820
ping @jkbradley ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132764129
Oh, sorry!
I think moving the example and providing some guidance about how to choose
evaluators/validators is sufficient for now.
---
If your project is
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132753058
> otherwise combinatorial complexity is going to bite us hard.
lol. That is not what I had meant. Sorry I should be more clear from here
on.
In other
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132747204
I don't think we need code examples for every possible combination,
otherwise combinatorial complexity is going to bite us hard.
We can:
* List all the
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132742762
That sounds like a great idea. But do you have better suggestions for an
example? I would have to use a cross-validator and tune it anyway and I'm
afraid there will be
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132697649
+1 for @mengxr 's suggestion on JIRA to break this example into a separate
`ml-evaluation.md` section; the examples in `ml-guide` are becoming monolithic
and breaki
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8304#discussion_r37439918
--- Diff: docs/ml-guide.md ---
@@ -832,9 +842,12 @@ Pipeline pipeline = new Pipeline()
// We now treat the Pipeline as an Estimator, wrapping it in a
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8304#discussion_r37439902
--- Diff: docs/ml-guide.md ---
@@ -710,9 +717,12 @@ val pipeline = new Pipeline()
// We now treat the Pipeline as an Estimator, wrapping it in a
Cro
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8304#discussion_r37439755
--- Diff: docs/ml-guide.md ---
@@ -645,6 +645,13 @@ An important task in ML is *model selection*, or using
data to find the best mod
Currently, `spa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8304#discussion_r37439565
--- Diff: docs/ml-guide.md ---
@@ -645,6 +645,13 @@ An important task in ML is *model selection*, or using
data to find the best mod
Currently, `spa
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/8304#discussion_r37439587
--- Diff: docs/ml-guide.md ---
@@ -645,6 +645,13 @@ An important task in ML is *model selection*, or using
data to find the best mod
Currently, `spa
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132463778
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132463782
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132463495
[Test build #41221 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41221/console)
for PR 8304 at commit
[`4a4d7a6`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132462068
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132462067
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132460848
[Test build #41221 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41221/consoleFull)
for PR 8304 at commit
[`4a4d7a6`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132460493
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132460487
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132459140
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132459097
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/8304#issuecomment-132458166
@mengxr
I thought it is unnecessary to add a separate guide for evaluators and
hence added a note within the existing example.
---
If your project is set up
GitHub user MechCoder opened a pull request:
https://github.com/apache/spark/pull/8304
[SPARK-9911] [DOC] [ML] Update Userguide for Evaluator
I added a small note about the different types of evaluator and the metrics
used.
You can merge this pull request into a Git repository by r
27 matches
Mail list logo
