Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-131209839
Merging this in master (not branch-1.5).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-131195304
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130555772
[Test build #40732 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40732/console)
for PR 8159 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130555873
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130890183
Does the new function needs to be public? Can it be private[spark] ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/8159#discussion_r37034675
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1150,6 +1150,25 @@ class DataFrame private[sql](
}
/**
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130903532
ML does not need it to be public.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130870552
The ML changes look good. (Thanks for adding this.)
The new method looks fine, unless you want to reduce code duplication.
---
If your project is set up for
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130903815
OK @cloud-fan let's make this private[spark] for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130935142
[Test build #40841 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40841/consoleFull)
for PR 8159 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130966333
The API change LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/8159#discussion_r37050371
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1150,6 +1150,23 @@ class DataFrame private[sql](
}
/**
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8159#discussion_r37050438
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -1150,6 +1150,23 @@ class DataFrame private[sql](
}
/**
+
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130957867
[Test build #40843 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40843/consoleFull)
for PR 8159 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130934034
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130934044
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130957124
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130957065
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130936203
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130936201
[Test build #40841 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40841/console)
for PR 8159 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130976967
[Test build #40843 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40843/console)
for PR 8159 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130977814
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130529657
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/8159
[SPARK-9929][SQL] support metadata in withColumn
in MLlib sometimes we need to set metadata for the new column, thus we will
alias the new column with metadata before call `withColumn` and in
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130529363
cc @marmbrus @rxin , this blocks https://github.com/apache/spark/pull/7957
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130529604
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8159#issuecomment-130531949
[Test build #40732 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40732/consoleFull)
for PR 8159 at commit
28 matches
Mail list logo
