Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-140217189
LGTM, thanks I'm merging this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39452893
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-140071327
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-140071326
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-140071206
[Test build #42421 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42421/console)
for PR 8642 at commit
[`c6e80a2`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-140041316
[Test build #42421 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42421/consoleFull)
for PR 8642 at commit
[`c6e80a2`](https://gith
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-140040686
@andrewor14 thanks for your reviewing. I updated this PR as per your
comments.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39381973
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LocalNode.scala ---
@@ -69,6 +69,23 @@ abstract class LocalNode(conf: SQLConf) extends
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39381902
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-140040052
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39381843
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-140039993
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139670309
@zsxwing I left some suggestions on reducing code duplication, but
otherwise this looks pretty good.
---
If your project is set up for it, you can reply to this emai
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39322010
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LocalNode.scala ---
@@ -69,6 +69,23 @@ abstract class LocalNode(conf: SQLConf) exten
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39321952
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNodeSuite.scala
---
@@ -0,0 +1,225 @@
+/*
+* Licensed to the
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39321800
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNodeSuite.scala
---
@@ -0,0 +1,225 @@
+/*
+* Licensed to the
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39321640
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39321471
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39320829
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39320538
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39320498
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39319838
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39319569
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39319530
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39319148
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39318962
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39316914
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/NestedLoopJoinNode.scala
---
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apac
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39315088
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/LocalNode.scala ---
@@ -108,6 +146,24 @@ abstract class LocalNode(conf: SQLConf) ext
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39311087
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/ExpandNode.scala
---
@@ -0,0 +1,63 @@
+/*
+* Licensed to the Apache Softwar
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139581381
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139581383
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139581215
[Test build #42336 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42336/console)
for PR 8642 at commit
[`4b18418`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139550058
[Test build #42336 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42336/consoleFull)
for PR 8642 at commit
[`4b18418`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139548116
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139548092
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139533219
[Test build #42330 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42330/console)
for PR 8642 at commit
[`514d3d2`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139511706
[Test build #42330 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42330/consoleFull)
for PR 8642 at commit
[`514d3d2`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139510723
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-139510766
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8642#discussion_r39235492
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/local/ExpandNode.scala
---
@@ -0,0 +1,62 @@
+/*
+* Licensed to the Apache Softwar
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-138323541
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-138323543
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-138323420
[Test build #42095 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42095/console)
for PR 8642 at commit
[`9055d8a`](https://github.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-138296051
[Test build #42095 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42095/consoleFull)
for PR 8642 at commit
[`9055d8a`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-138294238
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8642#issuecomment-138294215
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/8642
[SPARK-9996][SPARK-9997][SQL]Add local expand and NestedLoopJoin operators
This PR is in conflict with #8535 and #8573. Will update this one when they
are merged.
You can merge this pull request in
48 matches
Mail list logo
