[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/679#issuecomment-42402699 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-15 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/679#issuecomment-42485833 Out of curiosity, why can't this just be a normal val, rather than lazy? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-15 Thread chenghao-intel
GitHub user chenghao-intel opened a pull request: https://github.com/apache/spark/pull/679 [SQL] Fix Performance Issue in data type casting Using lazy val object instead of function in the class Cast, which improved the performance nearly by 2X in my local micro-benchmark. You can

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-15 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/679#issuecomment-42486106 That would cause issues when this type of expression is created before resolution has occurred. Specifically you are not allowed to call dataType on unresolved exp

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/679#issuecomment-42409174 Merged build finished. All automated tests passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/679#issuecomment-42402714 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/679#issuecomment-42409179 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14766/ --- If your project

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/679 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-10 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/679#issuecomment-42481268 I thought we were already doing this. Good catch! @pwendell or @rxin, please merge. --- If your project is set up for it, you can reply to this email and have y

[GitHub] spark pull request: [SQL] Fix Performance Issue in data type casti...

2014-05-10 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/679#issuecomment-42481869 Thanks. Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena