[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected

2014-10-01 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2431#issuecomment-57555461 Thanks! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected

2014-10-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected

2014-09-17 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/2431 [SQL] Made Command.sideEffectResult protected Considering `Command.executeCollect()` simply delegates to `Command.sideEffectResult`, we no longer need to leave the latter `protected[sql]`. You

[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected

2014-09-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2431#issuecomment-55934164 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20471/consoleFull) for PR 2431 at commit

[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected

2014-09-17 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2431#issuecomment-55934389 @marmbrus Would be good to merge after #2226 since I made `InsertIntoHiveTable` a `Command` there and would have minor conflict with this one. --- If your project is

[GitHub] spark pull request: [SQL] Made Command.sideEffectResult protected

2014-09-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2431#issuecomment-55946577 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20471/consoleFull) for PR 2431 at commit