[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50442727 @witgo @pwendell I have already noticed there is not a configuration for timeout for ConnectionManager, but the timeout for ConnectionManager does not resolve this issue

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50454065 QA tests have started for PR 1619. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17350/consoleFull ---

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50456598 @sarutak I think add a heartbeat detection mechanism is a good solution --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50458592 QA results for PR 1619:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50458991 @sarutak [ConnectionManager.scala#L259](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/network/ConnectionManager.scala#L259) to deal

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50481678 QA tests have started for PR 1619. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17356/consoleFull ---

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50488823 QA results for PR 1619:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-28 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1619 [WIP][SPARK-2677]BasicBlockFetchIterator#next can wait forever You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark SPARK-2677

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50350399 QA tests have started for PR 1619. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17280/consoleFull ---

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-28 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50356870 QA results for PR 1619:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [WIP][SPARK-2677]BasicBlockFetchIterator#next ...

2014-07-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1619#issuecomment-50364421 Can you create a test for this? I'm not sure what happens here if the timeout is encountered. --- If your project is set up for it, you can reply to this email and