Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159091594
Reviewing now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159164089
> Do you mean a LDAModel.load(path) which can load both local and
distributed LDAModel? We can create a jira.
Yes, that's what I had in mind. That way, most
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159170379
LGTM. @hhbyyh Thanks for the updates! Is there anything left to do? If
not, can you please remove the "WIP" label? I can then merge it.
---
If your project is
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683880
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -486,6 +487,61 @@ class LocalLDAModel private[ml] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683892
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -593,7 +686,8 @@ class DistributedLDAModel private[ml] (
@Since("1.6.0")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683886
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -562,6 +618,43 @@ class DistributedLDAModel private[ml] (
*/
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683894
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -695,7 +789,7 @@ class LDA @Since("1.6.0") (
}
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683883
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -486,6 +487,61 @@ class LocalLDAModel private[ml] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683902
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala ---
@@ -39,10 +40,24 @@ object LDASuite {
}.map(v => new TestRow(v))
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683878
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -486,6 +487,61 @@ class LocalLDAModel private[ml] (
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683890
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -562,6 +618,43 @@ class DistributedLDAModel private[ml] (
*/
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159115884
Thanks for the PR! My only other comment is about the missing
DistributedLDAModel unit test.
In the future, I also want to add an object LDA which implements
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45683896
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -706,4 +800,6 @@ private[clustering] object LDA {
(docId,
Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/9894#discussion_r45688351
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala ---
@@ -562,6 +618,43 @@ class DistributedLDAModel private[ml] (
*/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159142586
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159142590
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159142495
**[Test build #46581 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46581/consoleFull)**
for PR 9894 at commit
Github user hhbyyh commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159136664
@jkbradley Thanks for review.
Do you mean a LDAModel.load(path) which can load both local and distributed
LDAModel? We can create a jira.
---
If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-159137662
**[Test build #46581 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46581/consoleFull)**
for PR 9894 at commit
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-158858912
LGTM. Merged into master and branch-1.6. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-158779300
**[Test build #46492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46492/consoleFull)**
for PR 9894 at commit
GitHub user hhbyyh opened a pull request:
https://github.com/apache/spark/pull/9894
[WIP] [SPARK-11847] [ML] Model export/import for spark.ml: LDA
Add read/write support to LDA, similar to ALS.
save/load for ml.LocalLDAModel is done.
For DistributedLDAModel, I'm not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-158782005
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-158781971
**[Test build #46492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46492/consoleFull)**
for PR 9894 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9894#issuecomment-158782006
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
25 matches
Mail list logo
