Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-183262779
Good Q. We thought it'd be simple at first too.
1. We need a notion of "out-of-dateness" which (a) supports different back
ends, and (b) works reliably
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-183198008
Just saw this got merged. I'm probably missing some context, but can
somebody explain to me why something so conceptually simple leads to such a big
patch?
---
If your
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8#discussion_r52614670
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -511,6 +545,14 @@ private[history] class FsHistoryProvider(conf:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182916241
**[Test build #51105 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51105/consoleFull)**
for PR 8 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182935190
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182943275
**[Test build #51117 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51117/consoleFull)**
for PR 8 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182918248
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182918247
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182943466
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182943471
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182935184
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shaneknapp commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182936245
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-183168840
merged to master, thanks @steveloughran!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182951382
**[Test build #2536 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2536/consoleFull)**
for PR 8 at commit
Github user shaneknapp commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182945362
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182951344
**[Test build #51119 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51119/consoleFull)**
for PR 8 at commit
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182949387
Plan to merge this a little later (assuming tests pass), any other comments?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182980532
**[Test build #51117 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51117/consoleFull)**
for PR 8 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182980915
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182980939
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-183001005
**[Test build #2536 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2536/consoleFull)**
for PR 8 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-183004244
**[Test build #51119 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51119/consoleFull)**
for PR 8 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-183005153
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-183005159
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-182403322
LGTM; unifying the different probes for new-ness makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8#discussion_r52465521
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -256,6 +269,215 @@ class HistoryServerSuite extends
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8#discussion_r52465565
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala ---
@@ -256,6 +269,215 @@ class HistoryServerSuite extends
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8#discussion_r52461110
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -511,6 +545,14 @@ private[history] class
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8#discussion_r52461352
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -551,6 +597,8 @@ private[history] class
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8#discussion_r52264218
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,669 @@
+/*
+ * Licensed to the Apache Software
GitHub user squito opened a pull request:
https://github.com/apache/spark/pull/8
[WebUI][SPARK-7889] HistoryServer updates UI for incomplete apps
When the HistoryServer is showing an incomplete app, it needs to check if
there is a newer version of the app available. It does
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/8#discussion_r52203370
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,669 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181507545
**[Test build #2524 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2524/consoleFull)**
for PR 8 at commit
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181502916
I realize that this doesn't address the fileSize / mod time issue that
@steveloughran had pointed out earlier -- if we go with this approach,
`checkForLogs` should be
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181502638
**[Test build #50929 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50929/consoleFull)**
for PR 8 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181500981
**[Test build #2524 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2524/consoleFull)**
for PR 8 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181537586
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181537583
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/8#discussion_r52220649
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala ---
@@ -0,0 +1,669 @@
+/*
+ * Licensed to the Apache
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181562007
**[Test build #50936 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50936/consoleFull)**
for PR 8 at commit
Github user squito commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181499494
Reviewers: note this was done primarily by @steveloughran , for now just
posting this as a potential simplification to consider vs.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181508356
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181508283
**[Test build #50929 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50929/consoleFull)**
for PR 8 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181508354
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181535668
**[Test build #2525 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2525/consoleFull)**
for PR 8 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181586315
**[Test build #2525 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2525/consoleFull)**
for PR 8 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181601313
**[Test build #50936 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50936/consoleFull)**
for PR 8 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181601687
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181601692
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181613600
**[Test build #2526 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2526/consoleFull)**
for PR 8 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8#issuecomment-181655431
**[Test build #2526 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2526/consoleFull)**
for PR 8 at commit
52 matches
Mail list logo
