[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55477120 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20245/consoleFull) for PR 2349 at commit [`61b2e72`](https://github.com/ap

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55476384 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20243/consoleFull) for PR 2349 at commit [`a95e7c8`](https://github.com/ap

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55429412 @jkbradley This contains API changes to python. Could you create a JIRA for it? Thanks! --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/2349#discussion_r17405363 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -706,8 +706,8 @@ class DecisionTreeSuite extends FunSuite with Local

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55221916 @davies Thanks for taking a look! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/2349#discussion_r17404967 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -706,8 +706,8 @@ class DecisionTreeSuite extends FunSuite with Lo

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/2349#discussion_r17404100 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -706,8 +706,8 @@ class DecisionTreeSuite extends FunSuite with Local

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55219010 This patch looks good to me, just one minor question. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55210270 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20126/consoleFull) for PR 2349 at commit [`95c479d`](https://github.com/a

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55207772 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/44/consoleFull) for PR 2349 at commit [`95c479d`](https://github.com/a

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55205681 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20126/consoleFull) for PR 2349 at commit [`95c479d`](https://github.com/ap

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2349#issuecomment-55203791 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/44/consoleFull) for PR 2349 at commit [`95c479d`](https://github.com/ap

[GitHub] spark pull request: [mllib] DecisionTree: Add minInstancesPerNode,...

2014-09-10 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/2349 [mllib] DecisionTree: Add minInstancesPerNode, minInfoGain params to example and Python API Added minInstancesPerNode, minInfoGain params to: * DecisionTreeRunner.scala example * Python AP