Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145974489
This looks good. I personally prefer to fail fast loudly since this is a
correctness issue. Many people don't pay attention to warnings these days,
especially in
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145966530
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145966515
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145968060
Actually looking at this again, I think our only option is to log a
message. It is possible that the `SparkContext` was already created and passed
to us, in
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145972319
/cc @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145968432
[Test build #43289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43289/consoleFull)
for PR 8998 at commit
GitHub user harishreedharan opened a pull request:
https://github.com/apache/spark/pull/8998
[streaming] SPARK-10955. Disable dynamic allocation for Streaming appâ¦
â¦lications.
Dynamic allocation can be painful for streaming apps and can lose data. The
one drawback
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145966395
/cc @vanzin @tdas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145968943
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145968956
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145983548
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145983545
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145997044
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145997065
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145983265
[Test build #43290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43290/console)
for PR 8998 at commit
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145996934
Added config parameter to enable it if the user really wants to enable
dynamic allocation
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145980725
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145980547
[Test build #43289 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43289/console)
for PR 8998 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145980723
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145985862
Yeah, looks fine to me. Perhaps an internal config option so that the check
can be disabled? e.g. if someone wants to actually try it out and see how it
behaves without
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145999062
[Test build #43299 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43299/consoleFull)
for PR 8998 at commit
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146012980
I don't have a strong preference for the config name. @vanzin, @andrewor14
- like the current name or the one which @markgrover suggested? Vote please :)
---
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146016788
Also please update the PR title to be similar to other PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user harishreedharan commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146017855
As I said, I don't mind either. But in this case, we need to be
conservative. We can additional checks to see if WAL is enabled, but it is not
possible to
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146007357
> but we should document this new property
If you document it, it becomes public, and you need to document that you
removed it, and all sorts of things. Since
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146011686
[Test build #43299 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43299/console)
for PR 8998 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146011888
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146011885
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146016637
I strongly think that we should not add that require. It can break existing
streaming applications very easily. People might be using dynamic allocation
with direct kafka
Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-146006957
Pointing out the obvious here, but we should document this new property so
someone doesn't have to read the source code to figure out what's the name of
the property
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8998#issuecomment-145970342
[Test build #43290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43290/consoleFull)
for PR 8998 at commit
31 matches
Mail list logo
