Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42392487
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user funes commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42516407
@mengxr Updated the test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user funes commented on a diff in the pull request:
https://github.com/apache/spark/pull/661#discussion_r12413127
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BreezeVectorConversionSuite.scala
---
@@ -55,4 +55,16 @@ class BreezeVectorConversionSuite extends
Github user funes commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42387458
@mengxr Just added a test for sparse breeze by vector builder. Original
sparse breeze to vector test is still valid since no data copying should happen
in that case.
---
I
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42394656
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/661#discussion_r12414571
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BreezeVectorConversionSuite.scala
---
@@ -55,4 +55,16 @@ class BreezeVectorConversionSuite extends
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42575036
LGTM. Do you mind creating a JIRA for this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/661#discussion_r12414595
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BreezeVectorConversionSuite.scala
---
@@ -55,4 +55,16 @@ class BreezeVectorConversionSuite extends
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42623566
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42392701
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user funes commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42628022
Sorry that I didn't see this message earlier. I'd be glad to create a JIRA
if it is still appropriate. (I have to say I haven't read the how to
contribute wiki careful
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42623743
Thanks, merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/661
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42392717
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/661#discussion_r12389263
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/BreezeVectorConversionSuite.scala
---
@@ -55,4 +55,16 @@ class BreezeVectorConversionSuite extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42394657
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14759/
---
If your project
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/661#discussion_r12332278
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -136,7 +136,12 @@ object Vectors {
new DenseVector(v.toArray)
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42321616
@funes Could you add a unit test for this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42284169
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
GitHub user funes reopened a pull request:
https://github.com/apache/spark/pull/661
Bug fix of sparse vector conversion
Fixed a small bug caused by the inconsistency of index/data array size and
vector length.
You can merge this pull request into a Git repository by running:
$
Github user funes commented on a diff in the pull request:
https://github.com/apache/spark/pull/661#discussion_r12311565
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -136,7 +136,7 @@ object Vectors {
new DenseVector(v.toArray) //
Github user funes closed the pull request at:
https://github.com/apache/spark/pull/661
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/661#discussion_r12311400
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -136,7 +136,7 @@ object Vectors {
new DenseVector(v.toArray) /
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/661#issuecomment-42266149
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
GitHub user funes opened a pull request:
https://github.com/apache/spark/pull/661
Bug fix of sparse vector conversion
Fixed a small bug caused by the inconsistency of index/data array size and
vector length.
You can merge this pull request into a Git repository by running:
$ g
25 matches
Mail list logo
