[GitHub] spark pull request: ConnectionManager throws out of Could not fin...

2014-07-26 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1603 ConnectionManager throws out of Could not find reference for received ack message xxx exception. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: ConnectionManager throws out of Could not fin...

2014-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1603#issuecomment-50237469 QA tests have started for PR 1603. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17221/consoleFull ---

[GitHub] spark pull request: ConnectionManager throws out of Could not fin...

2014-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1603#issuecomment-50237601 QA results for PR 1603:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: ConnectionManager throws out of Could not fin...

2014-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1603#issuecomment-50237979 QA tests have started for PR 1603. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17223/consoleFull ---

[GitHub] spark pull request: ConnectionManager throws out of Could not fin...

2014-07-26 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1603#issuecomment-50238872 Does the movement of the status modification into the synchronized block change anything? It seems the only effective change here is downgrading an exception to a log

[GitHub] spark pull request: ConnectionManager throws out of Could not fin...

2014-07-26 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1603#issuecomment-50239511 Throw an exception here cause `System.exit(ExecutorExitCode.UNCAUGHT_EXCEPTION)` is called. This is not necessary. --- If your project is set up for it, you can reply

[GitHub] spark pull request: ConnectionManager throws out of Could not fin...

2014-07-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1603#issuecomment-50240022 QA results for PR 1603:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test